Pop all evthandlers #108

Merged
merged 2 commits into from Oct 17, 2013

Conversation

Projects
None yet
2 participants
@RobinD42
Member

RobinD42 commented Apr 24, 2013

wx 2.9 requires that all pushed wx.EvtHandlers be popped before a window is destroyed. This change is also compatible with 2.8 and may also solve part of the memory leak issue reported in issue #98.

@corranwebster

This comment has been minimized.

Show comment Hide comment
@corranwebster

corranwebster May 11, 2013

Member

Should a similar change be made in PyFace?

Member

corranwebster commented May 11, 2013

Should a similar change be made in PyFace?

@corranwebster

This comment has been minimized.

Show comment Hide comment
@corranwebster

corranwebster May 20, 2013

Member

This has been sitting here for a while, probably because no-one feels fluent enough in the Wx internals. I'd suggest going ahead and merging this, @RobinD42 as long as you are comfortable with it and willing to deal with issues that might arise from the change.

Member

corranwebster commented May 20, 2013

This has been sitting here for a while, probably because no-one feels fluent enough in the Wx internals. I'd suggest going ahead and merging this, @RobinD42 as long as you are comfortable with it and willing to deal with issues that might arise from the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment