Update trail watch review event endpoint#1245
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the entire trail watch command to consume code-review SSE events from the new trail-scoped endpoint while preserving existing Accept: text/event-stream negotiation via the stream client.
Changes:
- Updated the streamed endpoint from query-based
/api/v1/review-events?...to/api/v1/trails/:trail_id/review/events. - Updated
reviewEventsPathto build the new path usingurl.PathEscapefor the trail ID segment. - Adjusted unit test expectations to match the new endpoint path and escaping behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/entire/cli/trail_watch_cmd.go | Updates help text and switches reviewEventsPath to the new trail-scoped review events SSE endpoint. |
| cmd/entire/cli/trail_watch_cmd_test.go | Updates TestReviewEventsPath to validate the new endpoint path and path-segment escaping. |
dee3523 to
24d48ab
Compare
Entire-Checkpoint: 2422cd59643f
24d48ab to
acd3d01
Compare
Soph
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
entire trail watchatGET /api/v1/trails/:trail_id/reviews/eventsAccept: text/event-streamSSE negotiation through the existing stream clienttrail.idfield from trail list responses before constructing the stream URLTests
mise exec -- go test ./cmd/entire/cli ./cmd/entire/cli/apimise exec -- golangci-lint run ./cmd/entire/cli ./cmd/entire/cli/api