Add lint and fail phase for root lint script. #221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should prevent any lint failing code to pass in presubmit prior to the code being landed in source control.
|
#149 aimed to do this, but happy to close and let you take over! |
|
Ah apologies! I missed your change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent any lint failing code to pass in presubmit prior to
the code being landed in source control.
Note: currently lint is not set to run during presubmit, however we can enable this! Doing this class of enable will be a
large-scale-changeby running prettier to reformat all code prior to enabling the lint to minimize code-churn for all contributors.