Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error if custom email template not found #108

Closed
sm-md-lg opened this issue Jun 12, 2020 · 2 comments
Closed

No error if custom email template not found #108

sm-md-lg opened this issue Jun 12, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@sm-md-lg
Copy link

Description

When using a custom email template for customer notifications, an error is not thrown if the custom template is not found. It appears to automatically use the default template.

This may not be a bug but a decision you've made, if so ignore this report. My feelings though is that an error should be thrown so the issue can be diagnosed easier (in my case a misspelled path).

Additional info

  • Craft version: 3.4.16
  • PHP version: 7.2.24-0ubuntu0.18.04.6
  • Database driver & version: mysqlnd 5.0.12-dev
  • Plugin version: 2.7.0
  • Is SCA and Stripe Checkout enabled?: SCA: not enabled, Stripe Checkout not enabled.
@andrelopez andrelopez self-assigned this Jun 16, 2020
@andrelopez andrelopez added the bug Something isn't working label Jun 16, 2020
@andrelopez
Copy link
Member

This is a UI issue, we'll add support for suggesting templates field. Thanks

@andrelopez
Copy link
Member

Hi @sm-md-lg We just released Stripe Payments v2.7.2 with a fix to this issue (we added the autosuggest field that will prevent this kind of issue, but we default to the default template if the template overrides does not exist). Thanks for reporting

Best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants