From 70415b799e6807520635e67fb09efa146e396056 Mon Sep 17 00:00:00 2001 From: Tomer Heber Date: Mon, 20 Feb 2023 08:52:46 -0600 Subject: [PATCH 1/2] Chore: deprecate 'external_id' --- env0/resource_aws_credentials.go | 1 + env0/resource_cost_credentials.go | 1 + 2 files changed, 2 insertions(+) diff --git a/env0/resource_aws_credentials.go b/env0/resource_aws_credentials.go index 6fa63f80..537b9643 100644 --- a/env0/resource_aws_credentials.go +++ b/env0/resource_aws_credentials.go @@ -38,6 +38,7 @@ func resourceAwsCredentials() *schema.Resource { ForceNew: true, ConflictsWith: []string{"access_key_id"}, RequiredWith: []string{"arn"}, + Deprecated: "field will be removed in the near future", }, "access_key_id": { Type: schema.TypeString, diff --git a/env0/resource_cost_credentials.go b/env0/resource_cost_credentials.go index 08be47bd..1fd8ab8d 100644 --- a/env0/resource_cost_credentials.go +++ b/env0/resource_cost_credentials.go @@ -29,6 +29,7 @@ func resourceCostCredentials(providerName string) *schema.Resource { Sensitive: true, ForceNew: true, Required: true, + Deprecated: "field will be removed in the near future", }, } From d73665bddc3f291de96f463712a06d866dce4b50 Mon Sep 17 00:00:00 2001 From: Tomer Heber Date: Wed, 22 Feb 2023 17:44:46 -0600 Subject: [PATCH 2/2] updated schema based on PR feedback --- env0/resource_aws_credentials.go | 1 - env0/resource_cost_credentials.go | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/env0/resource_aws_credentials.go b/env0/resource_aws_credentials.go index 537b9643..fcff5541 100644 --- a/env0/resource_aws_credentials.go +++ b/env0/resource_aws_credentials.go @@ -37,7 +37,6 @@ func resourceAwsCredentials() *schema.Resource { Sensitive: true, ForceNew: true, ConflictsWith: []string{"access_key_id"}, - RequiredWith: []string{"arn"}, Deprecated: "field will be removed in the near future", }, "access_key_id": { diff --git a/env0/resource_cost_credentials.go b/env0/resource_cost_credentials.go index 1fd8ab8d..31fd6f17 100644 --- a/env0/resource_cost_credentials.go +++ b/env0/resource_cost_credentials.go @@ -28,7 +28,7 @@ func resourceCostCredentials(providerName string) *schema.Resource { Description: "the aws role external id", Sensitive: true, ForceNew: true, - Required: true, + Optional: true, Deprecated: "field will be removed in the near future", }, }