Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubocop fixes #62

Merged
merged 2 commits into from Feb 8, 2020
Merged

Rubocop fixes #62

merged 2 commits into from Feb 8, 2020

Conversation

@orien
Copy link
Member

orien commented Feb 8, 2020

Context

The CI build tests against Ruby 2.1 and 2.2. On these Ruby versions, we use older versions of Rubocop (0.57.2 and 0.68.1 respectively) because newer versions of Rubocop have dropped support for these older Ruby versions. As such we need a Rubocop config that supports these old versions.

The latest versions of Rubocop have introduced cop name changes that breaks our .rubocop.yml config. If we make the required changes to the config, these older versions of Rubocop will error.

Change

Pin Rubocop to the latest version that supports our .rubocop.yml configuration.

Consequences

This allows us to continue supporting these old versions of Ruby.

When we drop support for Ruby 2.1 and 2.2, we can investigate unpinning this gem.

@orien orien merged commit 77dbbee into master Feb 8, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@orien orien deleted the rubocop-fixes branch Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.