Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GPG secret parameter resolver #295

Merged
merged 5 commits into from Jan 14, 2020
Merged

Conversation

@orien
Copy link
Member

orien commented Jan 13, 2020

Please add stack_master-gpg_parameter_resolver to your bundle to continue using the GPG parameter resolving functionality.

orien added 2 commits Jan 13, 2020
@orien orien requested a review from patrobinson Jan 13, 2020
@patrobinson

This comment has been minimized.

Copy link
Contributor

patrobinson commented Jan 13, 2020

@orien there's a few references still in the README. Can we replace these with links to the gpg gem?

@orien

This comment has been minimized.

Copy link
Member Author

orien commented Jan 14, 2020

Copy link
Contributor

patrobinson left a comment

Thanks a lot for your work

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@@ -9,7 +9,6 @@ class StackDefinition
:notification_arns,
:base_dir,
:template_dir,
:secret_file,

This comment has been minimized.

Copy link
@patrobinson

patrobinson Jan 14, 2020

Contributor

The stack definition still needs to contain this because the GPG resolver depends on it https://github.com/envato/stack_master-gpg_parameter_resolver/blob/master/lib/stack_master/parameter_resolvers/secret.rb#L43

This comment has been minimized.

Copy link
@orien

orien Jan 14, 2020

Author Member

The GPG Parameter Resolver actually adds this back in.

This is a rather dubious approach though. Thoughts?

This comment has been minimized.

Copy link
@orien

orien Jan 14, 2020

Author Member

Actually, I'm preferring to move this into the GPG gem. That way it doesn't need to be supported in StackMaster, we can make a clean break with version 2.

Later we could re-work the GPG Parameter Resolver to not use this configuration.

This comment has been minimized.

Copy link
@patrobinson

patrobinson Jan 14, 2020

Contributor

Wholly monkey patching that's ugly.

Ok let's leave it as is and refactor for a v1 of GPG parameter resolver.

Co-Authored-By: Patrick Robinson <patrick.robinson@envato.com>
@orien orien merged commit d30fe87 into master Jan 14, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@orien orien deleted the remove-secret-parameter-resolver branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.