Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Move ios_tests to use Engflow's remote execution #1697

Merged
merged 33 commits into from Aug 18, 2021

Conversation

lfpino
Copy link
Contributor

@lfpino lfpino commented Aug 12, 2021

Description:
CI: Move ios_tests to use Engflow's remote execution. Also extend the pattern to run the ios_tests workflow when the flow itself is modified.

Before (~1h20min):
Before_iostests

After (~20min):
Screenshot from 2021-08-13 00-52-37

Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

lfpino and others added 11 commits August 11, 2021 23:07
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
lfpino and others added 4 commits August 12, 2021 23:10
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@lfpino lfpino marked this pull request as ready for review August 12, 2021 21:57
@lfpino lfpino changed the title CI: Move iotests to use Engflow's remote execution CI: Move ios_tests to use Engflow's remote execution Aug 12, 2021
@lfpino
Copy link
Contributor Author

lfpino commented Aug 12, 2021

/cc @ulfjack @goaway

lfpino and others added 4 commits August 14, 2021 16:14
This reverts commit 1adf02d.

Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
lfpino and others added 5 commits August 14, 2021 16:33
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@lfpino
Copy link
Contributor Author

lfpino commented Aug 16, 2021

/cc @ulfjack @goaway can you please take a look?

@goaway goaway self-requested a review August 17, 2021 12:02
@lfpino
Copy link
Contributor Author

lfpino commented Aug 17, 2021

This is working now after the latest config changes in the cluster

@goaway goaway merged commit 76a2d8f into envoyproxy:main Aug 18, 2021
Copy link
Contributor

@goaway goaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Approved. Forgot to click.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants