Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Move MacOS android_test workflows to Engflow's remote execution #1705

Merged
merged 25 commits into from Sep 13, 2021

Conversation

lfpino
Copy link
Contributor

@lfpino lfpino commented Aug 16, 2021

Signed-off-by: Luis Fernando Pino Duque luis@engflow.com

Description:
Move the Java/Kotlin MacOS part of the android_test workflow to Engflow's remote execution and improve build times by ~10x

Before (~1hr)
Screenshot from 2021-09-13 21-44-14

After (~7min)
Screenshot from 2021-09-13 21-44-40

The remaining android_test Linux workflow requires some Java setup so it'll be done in a subsequent PR

Risk Level: Low
Testing: See android_build and android_test checks
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@goaway goaway self-requested a review August 17, 2021 12:02
lfpino and others added 24 commits August 17, 2021 15:39
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
This reverts commit 36d6c57.

Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@lfpino lfpino changed the title CI: Move android workflows to Engflow's remote execution CI: Move Java/Kotlin MacOS workflows to Engflow's remote execution Sep 13, 2021
@lfpino lfpino changed the title CI: Move Java/Kotlin MacOS workflows to Engflow's remote execution CI: Move MacOS android_test workflows to Engflow's remote execution Sep 13, 2021
@lfpino lfpino marked this pull request as ready for review September 13, 2021 19:47
Copy link
Contributor

@goaway goaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@goaway goaway merged commit 1e8c702 into envoyproxy:main Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants