CI: Move asan workflow to Engflow's remote execution#1745
Merged
Conversation
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Contributor
Author
|
/cc @goaway |
goaway
approved these changes
Aug 31, 2021
Contributor
|
@lfpino I just noticed that leak sanitization has been turned off. As much as I really would like to merge this, we've relied on leak sanitization to catch issues in the past, and they have the potential to be quite disastrous on mobile devices. Is it possible to update our tests so that we can leave this enabled? |
goaway
requested changes
Aug 31, 2021
goaway
left a comment
goaway
left a comment
Contributor
There was a problem hiding this comment.
Changing review status until we can discuss leak detection further.
Contributor
Author
|
I understand and thanks for taking a look. Let me see if I can find an alternative and I'll get back to you. |
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Contributor
Author
|
I found a different workaround that doesn't require deactivating leak sanitization. Please take a look! |
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Contributor
Author
|
Fully cached asan builds are down to 3 minutes! |
goaway
approved these changes
Sep 2, 2021
carloseltuerto
pushed a commit
to carloseltuerto/envoy-mobile
that referenced
this pull request
Sep 7, 2021
Description: Due to google/sanitizers#916 we add an extra capability (SYS_PTRACE) to the remote execution docker container, we do this by adding a new Clang ASAN toolchain. Otherwise, dangling threads can fail the test during teardown (example with a previous run: https://github.com/envoyproxy/envoy-mobile/runs/3443649963). Risk Level: Low Testing: See asan workflow Docs Changes: N/A Release Notes: N/A Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
goaway
pushed a commit
that referenced
this pull request
Sep 10, 2021
Description: Move tsan workflow to Engflow's remote execution Same as #1745 but using a couple of tsan flags instead of asan. Using a separate config for modularity. Risk Level: Low Testing: See tsan workflow Docs Changes: N/A Release Notes: N/A Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 28, 2022
Description: This change is a no-op that will be used for switching more CI workflows to Engflow's remote execution. See envoyproxy/envoy-mobile#1745 for preliminary results. Risk Level: Low Testing: Manually tested Docs Changes: N/A Release Notes: N/A Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 28, 2022
Description: Move tsan workflow to Engflow's remote execution Same as envoyproxy/envoy-mobile#1745 but using a couple of tsan flags instead of asan. Using a separate config for modularity. Risk Level: Low Testing: See tsan workflow Docs Changes: N/A Release Notes: N/A Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
Description: This change is a no-op that will be used for switching more CI workflows to Engflow's remote execution. See envoyproxy/envoy-mobile#1745 for preliminary results. Risk Level: Low Testing: Manually tested Docs Changes: N/A Release Notes: N/A Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
Description: Move tsan workflow to Engflow's remote execution Same as envoyproxy/envoy-mobile#1745 but using a couple of tsan flags instead of asan. Using a separate config for modularity. Risk Level: Low Testing: See tsan workflow Docs Changes: N/A Release Notes: N/A Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
CI: Move asan workflow to Engflow's remote execution and cut build times by 5x
Before (~2hr):
After (~20min):
Due to google/sanitizers#916 we add an extra capability (SYS_PTRACE) to the remote execution docker container, we do this by adding a new Clang ASAN toolchain. Otherwise, dangling threads can fail the test during teardown (example with a previous run: https://github.com/envoyproxy/envoy-mobile/runs/3443649963).
Risk Level: Low
Testing: See asan workflow
Docs Changes: N/A
Release Notes: N/A