Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Move Kotlin workflow in format to Engflow's remote execution #1759

Merged
merged 4 commits into from Aug 31, 2021

Conversation

lfpino
Copy link
Contributor

@lfpino lfpino commented Aug 27, 2021

Signed-off-by: Luis Fernando Pino Duque luis@engflow.com

Description:
CI: Move Kotlin workflow in format to Engflow's remote execution and cut format workflow build time by a half.

Before:
Screenshot from 2021-08-31 00-21-47

After:
Screenshot from 2021-08-31 00-21-54

Risk Level: Low
Testing: See format workflow
Docs Changes: N/A
Release Notes: N/A

@lfpino lfpino marked this pull request as ready for review August 30, 2021 22:23
@lfpino
Copy link
Contributor Author

lfpino commented Aug 30, 2021

/cc @goaway

@goaway
Copy link
Contributor

goaway commented Aug 30, 2021

Thanks @lfpino this is great. I'm wondering though, would we want this to be done on linux ultimately?

@lfpino
Copy link
Contributor Author

lfpino commented Aug 30, 2021

Since it's currently running on MacOS I'm trying to not divert from the current semantics to avoid doing too many changes at the same time.

My suggestion would be to merge this and file an issue as a follow-up to move this to Linux. Sometimes it's trivial to move these flows around but I gotta test it out.

What do you think?

@goaway goaway self-assigned this Aug 30, 2021
@goaway goaway self-requested a review August 30, 2021 23:16
@goaway goaway merged commit d8965af into envoyproxy:main Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants