CI: Move Kotlin workflow in format to Engflow's remote execution - #1759
Merged
Conversation
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
lfpino
marked this pull request as ready for review
August 30, 2021 22:23
Contributor
Author
|
/cc @goaway |
Contributor
|
Thanks @lfpino this is great. I'm wondering though, would we want this to be done on linux ultimately? |
Contributor
Author
|
Since it's currently running on MacOS I'm trying to not divert from the current semantics to avoid doing too many changes at the same time. My suggestion would be to merge this and file an issue as a follow-up to move this to Linux. Sometimes it's trivial to move these flows around but I gotta test it out. What do you think? |
goaway
self-requested a review
August 30, 2021 23:16
goaway
approved these changes
Aug 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luis Fernando Pino Duque luis@engflow.com
Description:
CI: Move Kotlin workflow in format to Engflow's remote execution and cut format workflow build time by a half.
Before:
After:
Risk Level: Low
Testing: See format workflow
Docs Changes: N/A
Release Notes: N/A