From e3f648d4ffa6cd4a772de960ed9227f95ff272cc Mon Sep 17 00:00:00 2001 From: Anton Kaymakchi Date: Mon, 24 Jun 2024 11:01:05 +0000 Subject: [PATCH] Add clarifying comment about virtual domain name in proto files Signed-off-by: Anton Kaymakchi --- api/envoy/data/dns/v3/dns_table.proto | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/api/envoy/data/dns/v3/dns_table.proto b/api/envoy/data/dns/v3/dns_table.proto index 1816a304405e..5f0275dea6b7 100644 --- a/api/envoy/data/dns/v3/dns_table.proto +++ b/api/envoy/data/dns/v3/dns_table.proto @@ -128,7 +128,10 @@ message DnsTable { option (udpa.annotations.versioning).previous_message_type = "envoy.data.dns.v2alpha.DnsTable.DnsVirtualDomain"; - // A domain name for which Envoy will respond to query requests + // A domain name for which Envoy will respond to query requests. + // Wildcard records are supported on the first label only, e.g. `*.example.com` or `*.subdomain.example.com`. + // Names such as `*example.com`, `subdomain.*.example.com`, `*subdomain.example.com`, etc + // are not valid wildcard names and asterisk will be interpreted as a literal `*` character. string name = 1 [(validate.rules).string = {min_len: 1 well_known_regex: HTTP_HEADER_NAME}]; // The configuration containing the method to determine the address of this endpoint