New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP socket options may be applied to UDS upstream host connections #4175

Closed
htuch opened this Issue Aug 15, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@htuch
Copy link
Member

htuch commented Aug 15, 2018

While investigating https://oss-fuzz.com/v2/testcase-detail/6542943040045056, @anirudhmurali and I figured out that we were applying IP socket option (specifically the source_address in upstream_bind_config) to a UDS host. This seems broken.

We can either flag this during config loading or silently ignore/warn at runtime as a resolution. I haven't done a deep dive yet into the code, but I think it might be the case that we don't know until something like EDS whether a host is IP or UDS (does EDS force IP only? can't remember). Could we have a mix of IP and UDS hosts in a cluster? @mattklein123

@mattklein123

This comment has been minimized.

Copy link
Member

mattklein123 commented Aug 16, 2018

We can either flag this during config loading or silently ignore/warn at runtime as a resolution. I haven't done a deep dive yet into the code, but I think it might be the case that we don't know until something like EDS whether a host is IP or UDS (does EDS force IP only? can't remember). Could we have a mix of IP and UDS hosts in a cluster? @mattklein123

TBH I don't remember. Someone will need to look at the code. I don't see any reason why EDS can't expose a UDS host or a mix of hosts.

@stale

This comment has been minimized.

Copy link

stale bot commented Sep 15, 2018

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 15, 2018

@htuch

This comment has been minimized.

Copy link
Member

htuch commented Sep 16, 2018

IIRC, we merged a PR that supported mixed UDS/TCP hosts, so will close this one out.

@htuch htuch closed this Sep 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment