Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] A feature to propagate context within trace #5266

Closed
nakabonne opened this issue Dec 11, 2018 · 2 comments

Comments

@nakabonne
Copy link

commented Dec 11, 2018

Title: [Question] A feature to propagate context within trace

Description:
Envoy has a feature to generate a span and automatically send it to a collector. This is a great feature.
However, we need to add application code so as to propagate the context between spans.
In order to achieve Envoy's goal "to abstract the network from application developers so that they can focus on business logic", I think Envoy should do the propagation.

I'd be grateful if you could tell the reason why does Envoy entrust propagation of context to application.
Thanks.

@objectiser

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

It would certainly be great if this was possible - however the problem is that the Envoy proxy has no way of knowing which outbound requests were caused by which inbound requests.

The only way that an outbound request can be correlated to an inbound request, and therefore reported as being part of the same trace instance, is if some correlating information from the inbound request is passed to the outbound request - which can only be achieved in the application code.

@nakabonne

This comment has been minimized.

Copy link
Author

commented Dec 11, 2018

Thank you for your prompt response.
I understand. Thank you for your perfect explanation.

@nakabonne nakabonne closed this Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.