golang extension: optimization: added noescape and nocallback directives for C functions. - #29396
Merged
Conversation
…ves for C functions. they could prevent the Go compiler from allocating function parameters on the heap. Signed-off-by: doujiang24 <doujiang24@gmail.com>
spacewander
reviewed
Sep 4, 2023
Signed-off-by: doujiang24 <doujiang24@gmail.com>
Member
Author
|
/retest |
Member
Author
|
seems the tests failed due to a bad network? https://github.com/envoyproxy/envoy/actions/runs/6072484811/job/16474468365?pr=29396 |
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
spacewander
approved these changes
Sep 5, 2023
Member
Author
|
/retest |
Member
Author
|
ci is happy now, it's good to merge. cc @wbpcode |
spacewander
pushed a commit
to spacewander/envoy
that referenced
this pull request
Sep 19, 2023
…ves for C functions. (envoyproxy#29396) * golang extension: optimization: added noescape and nocallback directives for C functions. they could prevent the Go compiler from allocating function parameters on the heap. Signed-off-by: doujiang24 <doujiang24@gmail.com> * add comment for the magic number. Signed-off-by: doujiang24 <doujiang24@gmail.com> --------- Signed-off-by: doujiang24 <doujiang24@gmail.com>
johnlanni
pushed a commit
to johnlanni/envoy
that referenced
this pull request
Mar 25, 2025
…ves for C functions. (envoyproxy#29396) * golang extension: optimization: added noescape and nocallback directives for C functions. they could prevent the Go compiler from allocating function parameters on the heap. Signed-off-by: doujiang24 <doujiang24@gmail.com> * add comment for the magic number. Signed-off-by: doujiang24 <doujiang24@gmail.com> --------- Signed-off-by: doujiang24 <doujiang24@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
they could prevent the Go compiler from allocating function parameters on the heap.
noescapeandnocallbackare new go1.22 cgo directives that help the Go compiler make better decisions. See golang/go#56378 for more context.