make golang http filter work with cgocheck - #29999
Merged
Merged
Conversation
repokitteh-read-only
Bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
doujiang24
marked this pull request as draft
October 6, 2023 10:08
doujiang24
force-pushed
the
fix-cgocheck
branch
from
October 11, 2023 15:34
56456d6 to
30b2361
Compare
doujiang24
changed the title
doujiang24
force-pushed
the
fix-cgocheck
branch
from
October 11, 2023 15:38
30b2361 to
4118285
Compare
Signed-off-by: doujiang24 <doujiang24@gmail.com>
Signed-off-by: doujiang24 <doujiang24@gmail.com>
doujiang24
force-pushed
the
fix-cgocheck
branch
from
October 12, 2023 01:09
4118285 to
bc7a493
Compare
doujiang24
marked this pull request as ready for review
October 12, 2023 03:21
spacewander
reviewed
Oct 12, 2023
spacewander
left a comment
spacewander
left a comment
Contributor
There was a problem hiding this comment.
Let's update the go.mod in example/ and test_data/
Signed-off-by: doujiang24 <doujiang24@gmail.com>
Member
Author
Thanks, updated the go.mod files related to golang HTTP extension. |
spacewander
approved these changes
Oct 13, 2023
Member
Author
|
it's good to merge, cc @wbpcode Thanks~ |
repokitteh-read-only
Bot
removed
the
deps
spacewander
pushed a commit
to spacewander/envoy
that referenced
this pull request
Oct 14, 2023
Signed-off-by: doujiang24 <doujiang24@gmail.com>
johnlanni
pushed a commit
to johnlanni/envoy
that referenced
this pull request
Mar 25, 2025
Signed-off-by: doujiang24 <doujiang24@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so that people do not have to set
GODEBUG=cgocheck=0.fix #25178
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]