local ratelimit: use new tokenbucket implementation#35207
Merged
wbpcode merged 3 commits intoJul 18, 2024
Conversation
Signed-off-by: wbpcode <wbphub@gmail.com>
mattklein123
previously approved these changes
Jul 16, 2024
Member
Author
|
Hah, the listener local rate limit and network local rate limit. |
Member
Author
Signed-off-by: wbpcode <wbphub@gmail.com>
Member
Author
|
/retest |
…ocal-ratelimit-tokenbucket
mattklein123
approved these changes
Jul 17, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Commit Message: local ratelimit: use new tokenbucket implementation
Additional Description:
Part of #34774.
Updated the token bucket implementation to use non-timer based token bucket. The tokens will be refilled when the token bucket is accessed and no dependency on the timer.
This behavior can be temporarily reverted by setting the runtime guard
envoy.reloadable_features.no_timer_based_rate_limit_token_bucketto false.Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.
[Optional Runtime guard:] envoy.reloadable_features.no_timer_based_rate_limit_token_bucket