golang: avoid setting invalid pointer in Golang side when header value is empty#35930
Merged
Conversation
…e is empty Signed-off-by: doujiang24 <doujiang24@gmail.com>
spacewander
approved these changes
Sep 2, 2024
Member
Author
|
It's ready to merge, thanks cc @phlax |
phlax
approved these changes
Sep 2, 2024
spacewander
pushed a commit
to mosn/envoy
that referenced
this pull request
Sep 6, 2024
…e is empty (envoyproxy#35930) Otherwise, Golang may panic when it found this invalid pointer. It's not easy to add a test case for it, since Golang only panic during GC. Commit Message: Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] Signed-off-by: doujiang24 <doujiang24@gmail.com>
johnlanni
pushed a commit
to johnlanni/envoy
that referenced
this pull request
Mar 25, 2025
…e is empty (envoyproxy#35930) Otherwise, Golang may panic when it found this invalid pointer. It's not easy to add a test case for it, since Golang only panic during GC. Commit Message: Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] Signed-off-by: doujiang24 <doujiang24@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, Golang may panic when it found this invalid pointer.
It's not easy to add a test case for it, since Golang only panic during GC.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]