Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Handle lists with and without spaces in XFF #3610
Per https://tools.ietf.org/html/rfc7239#section-7.1, spaces are allowed
This fixes #3607.
Signed-off-by: Raul Gutierrez Segales email@example.com
referenced this pull request
Jun 12, 2018
Having the utility fix in the same PR as the change to headers doesn't actually help if you don't roll everything out at once.
I'd honestly be inclined to roll back #3609, check this in, and wait [a month | a full release] before reapplying given there's 0 urgency on removing the whitespace. Alternately we could call it out much more clearly in the release notes that you must replace your upstream Envoys (which allow whitespace and no-whitespace) before replacing downstream Envoys (which change how the header looks) but that seems more dicey.
This is a good point. Sorry, didn't think about this very much when I mentioned to roll it together. Agre let's apply this first then wait a month or so for the other one. Can we open a tracking issue for that?