New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: fixes oss-fuzz: 9599, 9600 #3979

Merged
merged 2 commits into from Jul 31, 2018

Conversation

Projects
None yet
3 participants
@anirudhmurali
Copy link
Member

anirudhmurali commented Jul 28, 2018

Title: Fixes oss-fuzz: 9599, 9600

Description:

Both issues are due to ERROR: libFuzzer: out-of-memory because of the usage of a large integer in the corpus. Added max constraint validate rule to the appropriate field.

Risk Level: Low

Testing: Tested unit tests (bazel test //test/server:server_fuzz_test and bazel test //test/server/config_validation:config_fuzz_test), built and ran fuzzers with oss-fuzz.

Signed-off-by: Anirudh M m.anirudh18@gmail.com

fuzz: fixes oss-fuzz: 9599, 9600
Signed-off-by: Anirudh M <m.anirudh18@gmail.com>
@@ -123,5 +123,5 @@ message LocalityLbEndpoints {
// next highest priority group.
//
// Priorities should range from 0 (highest) to N (lowest) without skipping.
uint32 priority = 5;
uint32 priority = 5 [(validate.rules).uint32 = {gte: 0, lte: 128}];

This comment has been minimized.

@htuch

htuch Jul 30, 2018

Member

Thanks, this looks basically right. You don't need the gte: 0 though, since this is an unsigned int. @alyssawilk what do you think a sensible upper bound here is? Will 128 work? Seems reasonable to me.

addressed comments
Signed-off-by: Anirudh M <m.anirudh18@gmail.com>
@htuch

htuch approved these changes Jul 30, 2018

@mattklein123 mattklein123 merged commit eb5ea98 into envoyproxy:master Jul 31, 2018

12 checks passed

DCO All commits have a DCO sign-off from the author
Details
ci/circleci: api Your tests passed on CircleCI!
Details
ci/circleci: asan Your tests passed on CircleCI!
Details
ci/circleci: build_image Your tests passed on CircleCI!
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: filter_example_mirror Your tests passed on CircleCI!
Details
ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: ipv6_tests Your tests passed on CircleCI!
Details
ci/circleci: mac Your tests passed on CircleCI!
Details
ci/circleci: release Your tests passed on CircleCI!
Details
ci/circleci: tsan Your tests passed on CircleCI!
Details

nickrmc83 added a commit to thales-e-security/envoy that referenced this pull request Aug 23, 2018

fuzz: fixes oss-fuzz: 9599, 9600 (envoyproxy#3979)
Signed-off-by: Anirudh M <m.anirudh18@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment