Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ratelimit: link legacy proto when message is being used #4308

Merged
merged 1 commit into from
Aug 30, 2018
Merged

ratelimit: link legacy proto when message is being used #4308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions source/common/ratelimit/ratelimit_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ GrpcFactoryImpl::GrpcFactoryImpl(const envoy::config::ratelimit::v2::RateLimitSe

// TODO(junr03): legacy rate limit is deprecated. Remove this warning after 1.8.0.
if (!use_data_plane_proto_) {
// Force link time dependency on deprecated message type.
pb::lyft::ratelimit::RateLimit _ignore;
ENVOY_LOG_MISC(warn, "legacy rate limit client is deprecated, update your service to support "
"the data-plane-api defined rate limit service");
}
Expand Down