From 40472687d2806183b0d443fa793705d06c6a037d Mon Sep 17 00:00:00 2001 From: Xunzhuo Date: Mon, 30 Oct 2023 23:25:19 +0800 Subject: [PATCH] fix: testGatewayClassWithParamRef e2e test flaky (#2114) --- internal/provider/kubernetes/kubernetes_test.go | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/internal/provider/kubernetes/kubernetes_test.go b/internal/provider/kubernetes/kubernetes_test.go index cc3763edc9a..4eab96cd5a1 100644 --- a/internal/provider/kubernetes/kubernetes_test.go +++ b/internal/provider/kubernetes/kubernetes_test.go @@ -196,9 +196,19 @@ func testGatewayClassWithParamRef(ctx context.Context, t *testing.T, provider *P }, defaultWait, defaultTick) // Ensure the resource map contains the EnvoyProxy. - res, ok := resources.GatewayAPIResources.Load(gc.Name) - assert.Equal(t, ok, true) - assert.Equal(t, res.EnvoyProxy.Spec, ep.Spec) + require.Eventually(t, func() bool { + res, ok := resources.GatewayAPIResources.Load(gc.Name) + if !ok { + return false + } + + if res.EnvoyProxy != nil { + assert.Equal(t, res.EnvoyProxy.Spec, ep.Spec) + return true + } + + return false + }, defaultWait, defaultTick) } func testGatewayScheduledStatus(ctx context.Context, t *testing.T, provider *Provider, resources *message.ProviderResources) {