Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactory string matcher #2067

Closed
zhaohuabing opened this issue Oct 25, 2023 · 0 comments · Fixed by #2102
Closed

chore: refactory string matcher #2067

zhaohuabing opened this issue Oct 25, 2023 · 0 comments · Fixed by #2102
Assignees
@zhaohuabing
Labels
kind/enhancement New feature or request

Comments

@zhaohuabing
Copy link
Member

Description:

The string match types are a bit messy. They're defined in multiple APIs but look similar. For most EG APIs(Ratelimit and CORS for now, more in the future), the match types are just used to represent the StringMatcher XDS API.

What I'd like to change:

  • Create a common StringMatcher that can be used by Ratelimit, CORS, and other APIs that need plain string matching
  • Change the name of StringMatcher in Stats to avoid naming conflicting

I would like to raise a PR to refactor it if it makes sense.
@zhaohuabing zhaohuabing added the kind/enhancement New feature or request label Oct 25, 2023
@zhaohuabing zhaohuabing self-assigned this Oct 25, 2023
This was referenced Oct 25, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhaohuabing zhaohuabing

Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: refactor string match zhaohuabing/gateway
1 participant
@zhaohuabing