Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add spew dump for envoy-gateway config when starting up #1425

Merged
merged 1 commit into from
May 22, 2023

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented May 16, 2023

What type of PR is this?

feat: add spew dump for envoy-gateway config when starting up, as the envoy gateway config grows bigger and more complex.

we should provide a direct way in log to see how the config recieved by eg looks like.

What this PR does / why we need it:

image

Which issue(s) this PR fixes:

@Xunzhuo Xunzhuo requested a review from a team as a code owner May 16, 2023 07:16
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #1425 (63e6e5c) into main (e518a0e) will increase coverage by 0.09%.
The diff coverage is 0.00%.

❗ Current head 63e6e5c differs from pull request most recent head 9973eb3. Consider uploading reports for the commit 9973eb3 to get more accurate results

@@            Coverage Diff             @@
##             main    #1425      +/-   ##
==========================================
+ Coverage   61.96%   62.05%   +0.09%     
==========================================
  Files          79       79              
  Lines       11271    11275       +4     
==========================================
+ Hits         6984     6997      +13     
+ Misses       3827     3821       -6     
+ Partials      460      457       -3     
Impacted Files Coverage Δ
internal/cmd/server.go 15.75% <0.00%> (-0.45%) ⬇️

... and 2 files with indirect coverage changes

@qicz qicz added kind/enhancement New feature or request area/config Issues related to config management, e.g. Config Manager, Config Sources, etc. labels May 16, 2023
@qicz qicz added this to the 0.5.0-rc1 milestone May 16, 2023
Copy link
Member

@qicz qicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xunzhuo Xunzhuo requested a review from zirain May 17, 2023 02:28
@zirain
Copy link
Contributor

zirain commented May 22, 2023

could the output format be optimized, json or yaml is more readable.

Signed-off-by: bitliu <bitliu@tencent.com>
@zirain zirain added the cherrypick/release-v0.4 cherrypick to release/v0.4 label May 22, 2023
@zirain zirain merged commit 24208c3 into envoyproxy:main May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues related to config management, e.g. Config Manager, Config Sources, etc. cherrypick/release-v0.4 cherrypick to release/v0.4 kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants