New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching xDS responses #7

Open
kyessenov opened this Issue Oct 25, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@kyessenov
Contributor

kyessenov commented Oct 25, 2017

The management server has to maintain a cache of the desired configurations for all proxies in the mesh. Since there could be a lot more proxies that different configurations, it seems we want to be able to group proxy nodes into buckets.

Let's start with a generic bucketing function:

function nodeGroup(proxy api.Node): string

For example, we can use the cluster field in the node to group API responses if the cluster corresponds to the service cluster. Alternatively, we can use the generic metadata field in the node message to assign configuration to proxies (e.g. in kubernetes, we may use pod labels to uniequely identify sidecars).

The cache is a map from the node group and response type to the desired response:

var cache map[NodeGroup][ResponseType]proto.Message
@mattklein123

This comment has been minimized.

Member

mattklein123 commented Oct 25, 2017

For Lyft I think we basically need a bucket for a group, and then a bucket for canary also (which is a node concept). @junr03 can you work with @kyessenov to make sure we can accomplish this in the first version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment