Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed contents for "Implementing Metrics and Tracing Capabilities" #10

Merged
merged 2 commits into from Dec 27, 2019

Conversation

@kakakakakku
Copy link
Contributor

kakakakakku commented Dec 27, 2019

Hi, thank you for good contents 馃憤

What

I found some mistakes in index.json and step-start.md.

  • Step ID (See attached image)
  • Wrong port number

image

Thanks.

kakakakakku added 2 commits Dec 27, 2019
Signed-off-by: kakakakakku <y.yoshida22@gmail.com>
Signed-off-by: kakakakakku <y.yoshida22@gmail.com>
@@ -1,7 +1,7 @@
An initial envoy configuration file has been created at
`envoy.yaml`{{open}}

In this file, it is defined that the server will run with a listener using all network interfaces in port 8080.
In this file, it is defined that the server will run with a listener using all network interfaces in port 10000.

This comment has been minimized.

Copy link
@kakakakakku

kakakakakku Dec 27, 2019

Author Contributor

I think that port 8080 already updated to 10000 with #8 recently :octocat:

@BenHall BenHall merged commit 27fad80 into envoyproxy:master Dec 27, 2019
1 check passed
1 check passed
DCO DCO
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.