Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user-provided protoc plugins in Bazel #557

Closed
qdii opened this issue Jan 15, 2022 · 1 comment
Closed

Allow user-provided protoc plugins in Bazel #557

qdii opened this issue Jan 15, 2022 · 1 comment
Labels
Stale Activity has stalled on this issue/pull-request

Comments

@qdii
Copy link

qdii commented Jan 15, 2022

go_proto_library takes compilers as an argument, by which a user can decide the protoc plugins should be used against the protobuf.

In the current version, pgv_go_proto_library hardcodes @io_bazel_rules_go//proto:go_proto on top of its own validation-generating plugin.

However, this plugin doesn't generate source code for services present in the protobuf, but other plugins do.

To give the user some flexibility, please allow protoc plugins to be supplied be the user.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Activity has stalled on this issue/pull-request label Apr 16, 2022
@stale stale bot closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Activity has stalled on this issue/pull-request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant