New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS source map and compression options are configured wrong #502

Open
cameronmcefee opened this Issue Feb 14, 2018 · 2 comments

Comments

2 participants
@cameronmcefee

cameronmcefee commented Feb 14, 2018

  • I tried updating to the latest version.
    • I can't, there is an issue.
  • I Am on Windows
    • Ubuntu Bash on Windows
    • Fedora Bash on Windows
  • I Am on Linux
  • I Am on macOS

Description

I opted for an issue because I'm not sure what it takes to test or what the preferred intent is, but I noticed that the current configuration seems to be the opposite of what is expected.

CSS compression is always on if source maps are enabled. In when the env is development, source_maps are on by default. Thus, compression is on by default in development, which I assume is the opposite of what is desired.

Steps

  • Run Jekyll in dev mode
  • Check out the assets folder
  • CSS is compressed

Expected

CSS should be uncompressed

@envygeeks

This comment has been minimized.

Owner

envygeeks commented Feb 15, 2018

Ironically it is intended... but not for long. Sprockets only does (or did) SourceMaps when compression is enabled, because it's at compression time that they do SourceMap generation (though this might have changed, and I think recently I seen something in their source that indicated that, that or I read the source wrong at the time... which can happen sometimes,) so we had to enable compression to do SourceMaps or take over everything, which at the time with such a big release was something I wasn't willing to do.

Luckily, over the last few months of releases, I've slowly added in stuff that will allow me to eventually take over that one last piece of SourceMaps so I can do it myself at a particular time, this should be changing here soon (read: sometime this month,) but for now it was hacky way to get what you wanted without having to create too much surface at once.

@envygeeks envygeeks self-assigned this Feb 15, 2018

@envygeeks envygeeks added this to the v3.0.9 milestone Feb 15, 2018

@cameronmcefee

This comment has been minimized.

cameronmcefee commented Feb 15, 2018

Ah, that makes sense. Thanks for the explanation. I was also going to open an issue noting that the sourcemaps that are generated for me are pointing to the wrong sources, but unless you want to look into that now, I figure I'll wait to see if your future changes resolve the issue.

@envygeeks envygeeks modified the milestones: v3.0.9, v3.1.0, v4.0.0 Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment