ENYO-1020: implement "Save As" under the Text Editor #243

Merged
merged 23 commits into from Mar 29, 2013
Commits on Mar 20, 2013
  1. ENYO-1020: editor: turn `Save` button into `File` menu…

    asnowfix committed Mar 20, 2013
    - `File` menu has `Save`, `Save as` and `Close` menu items.
    
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
  2. ENYO-1020: Fix typo in `EditorSettings` breaking the `chrome` theme

    asnowfix committed Mar 20, 2013
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
  3. ENYO-1020: `DirectorySelectorPopup` is now `FileChooser`

    asnowfix committed Mar 20, 2013
    - `DirectorySelectorPopup` is now `Ares.FileChooser` defined by
      `utilities/source/FileChooser`
    - Move manual `style:`  into `Ares.css` as `.ares-filechooser*`
    
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
Commits on Mar 25, 2013
  1. ENYO-1020: Move top-level Ares MVC components under ares/source/

    asnowfix committed Mar 25, 2013
    - the `model/` tree was not attached to one of the functional Ares
      components (Ares, Harmonia, Phobos, Deimos)
    
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
  2. ENYO-2104: refresh Ares usage instructions

    asnowfix committed Mar 25, 2013
    - git clone is no longer the primary way of delivering Ares
    
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
  3. ENYO-1020: Move top-level Ares MVC components under ares/source/ (2/2)

    asnowfix committed Mar 25, 2013
    - fix broken package.js
    
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
  4. ENYO-1020: add /favicon.ico (avoid 404 in the logs...)

    asnowfix committed Mar 25, 2013
    - remove former ares.png files fetched from the Net with random license
    - add icon from Ares1 (https://ares.palm.com) as favicon.ico
    
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
  5. ENYO-2104: remove misleading runares.bat

    asnowfix committed Mar 25, 2013
    - prefer to use NPM-generated wrappers
    
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
Commits on Mar 27, 2013
  1. ENYO-1020: add `ares.basename()` and `ares.dirname()` utilities

    asnowfix committed Mar 27, 2013
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
Commits on Mar 28, 2013
  1. ENYO-1996: Added getParentOfSelected method on HermesFileTree

    Dominique Dumont authored and asnowfix committed Mar 28, 2013
Commits on Mar 29, 2013
  1. ENYO-1020: share waitPopup between Ares & Phobos

    Dominique Dumont authored and asnowfix committed Mar 28, 2013
    - Former implementation fires up one, the other one or both without
      a well-defined (or understandable) logic.
    - New implementation uses a single Ares#waitPopup that is usable via
      events by any module of Ares.
    
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
  2. ENYO-1020: refactor FileChooser to be a filePicker or a folderPicker

    asnowfix committed Mar 29, 2013
    - Still used by ProjectWizard (folderPicker)
    - Ready to be used by Phobos#saveAs (filePicker)
    
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
  3. ENYO-1020: implement Phobos#saveAs

    asnowfix committed Mar 29, 2013
    - UI interaction is handled by Phobos (text editor), which raises events
    - Events are trapped at the Ares level, which implements async file-
      system operations & report their success back to Phobos
    - FIXME: Phobos#saveAs() uses a common-JS type of completion callback
      (which is good) while Phobos#save() makes Ares directly call into
      Phobos's API (which is ugly, because Ares needs to know about an async
      operation completion public API which does not need to exist).
    - FIXME: saveAs popup does not show the folder where the current file
      is.  This is Ok in case of multiple saveAs (operation resumes in the
      same folder as before), but not for the first popup.
    
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
  4. ENYO-1020: remove dead code (Documents.js)

    asnowfix committed Mar 29, 2013
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
  5. ENYO-1020: update FS protocol description, following @opopova comment

    asnowfix committed Mar 29, 2013
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
  6. ENYO-1020: decrease FileChooser tracing level.

    asnowfix committed Mar 29, 2013
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
  7. ENYO-2089: refresh the FileTree after `Save As…`

    asnowfix committed Mar 29, 2013
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
  8. ENYO-2089: review comment: add Ares icon attribution

    asnowfix committed Mar 29, 2013
    - Also fix wiki formatting of former attribution (from open clipart)
    
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
  9. ENYO-1020: fix review comment (typo)

    asnowfix committed Mar 29, 2013
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
  10. ENYO-1020: fix bug introduced while addressing review comment

    asnowfix committed Mar 29, 2013
    - Use `refreshFile`, not `refreshFileTree`
    
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
  11. ENYO-1020: address review comment (clarify)

    asnowfix committed Mar 29, 2013
    - turn lambda function used in `async.waterfall` into local a nested one
      with a (hopefully descriptive) name `_prepareNewLocation`
    - Use `refreshFile`, not `refreshFileTree`
    
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>