Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

ENYO-2089: forbid running on node < 0.8.21 #244

Merged
merged 4 commits into from

2 participants

@asnowfix
Owner

Tested on Windows/IE9

- Avoid `socket hang up` on Windows

Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI francois-xavier.kowalski@hp.com

asnowfix added some commits
@asnowfix asnowfix ENYO-2089: forbid running on node < 0.8.21
- Avoid `socket hang up` on Windows

Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
1175bee
@asnowfix asnowfix ENYO-2089: currently working on 0.1.1 (to be released 2013-03-29)
- NPM version number incremented in package.json

Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
7b6f9c3
@yves-del-medico yves-del-medico commented on the diff
package.json
@@ -13,7 +13,7 @@
"url" : "http://github.com/enyojs/ares-project.git"
},
"engines": {
- "node" : "0.8.x >=0.8.19",
+ "node" : "0.8.x >=0.8.21",
@yves-del-medico Owner

This could be enforced at runtime in hermes/lib/checkNodeVersion.js

@asnowfix Owner

Good idea. I just added it to the stack of changes for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@yves-del-medico yves-del-medico merged commit 3328dc9 into from
@yves-del-medico

Tested on Windows
Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 29, 2013
  1. @asnowfix

    ENYO-2089: forbid running on node < 0.8.21

    asnowfix authored
    - Avoid `socket hang up` on Windows
    
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
  2. @asnowfix

    ENYO-2089: currently working on 0.1.1 (to be released 2013-03-29)

    asnowfix authored
    - NPM version number incremented in package.json
    
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
  3. @asnowfix

    ENYO-2089: forbid running on node < 0.8.21 (run-time check)

    asnowfix authored
    Enyo-DCO-1.1-Signed-off-by: Francois-Xavier KOWALSKI <francois-xavier.kowalski@hp.com>
  4. @asnowfix
This page is out of date. Refresh to see the latest.
Showing with 5 additions and 5 deletions.
  1. +3 −3 hermes/lib/checkNodeVersion.js
  2. +2 −2 package.json
View
6 hermes/lib/checkNodeVersion.js
@@ -1,8 +1,8 @@
(function() {
- var version = process.version.match(/v([0-9]+).([0-9]+)/);
- if (version[1] != 0 || version[2] < 8 || version[2] > 8) {
- console.error("Ares ide.js is only supported on Node.js version 0.8.x");
+ var version = process.version.match(/v([0-9]+).([0-9]+).([0-9]+)/);
+ if (version[1] != 0 || version[2] < 8 || version[2] > 8 || version[3] < 21) {
+ console.error("Ares ide.js only works on Node.js version 0.8.x >= 0.8.21");
process.exit(1);
}
View
4 package.json
@@ -1,6 +1,6 @@
{
"name": "ares-ide",
- "version": "0.1.0",
+ "version": "0.1.1",
"description": "A browser-based code editor and UI designer for Enyo 2 projects",
"keywords": ["ide", "enyo", "phonegap", "android", "ios", "windowsphone", "blackberry", "webos", "html5"],
"homepage": "https://github.com/enyojs/ares-project",
@@ -13,7 +13,7 @@
"url" : "http://github.com/enyojs/ares-project.git"
},
"engines": {
- "node" : "0.8.x >=0.8.19",
+ "node" : "0.8.x >=0.8.21",
@yves-del-medico Owner

This could be enforced at runtime in hermes/lib/checkNodeVersion.js

@asnowfix Owner

Good idea. I just added it to the stack of changes for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
"npm": "1.2.x"
},
"engineStrict": true,
Something went wrong with that request. Please try again.