Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed measurement discrepancies when parent elements have borders #209

Merged
merged 1 commit into from Dec 14, 2012

Conversation

Projects
None yet
2 participants
Contributor

onecrayon commented Dec 14, 2012

There was a shortcoming in the original viewport measuring code that would cause the coordinates to be off if one of the parent elements had a border; this push both fixes that issue and updates the test suite to verify the new logic.

Note that I also removed all the extraneous var keywords and reverted back to a comma-delimited variable instantiation; the problem in my original commit with global var assignment wasn't the comma pattern, it was the left = top = 0 pattern.

Updated viewport measuring code to adjust for borders on parent elements
Updated viewport measurement test to verify the border measurement logic
Enyo-DCO-1.1-Signed-off-by: Ian Beck <ian@onecrayon.com>

unwiredben added a commit that referenced this pull request Dec 14, 2012

Merge pull request #209 from onecrayon/viewport-measurements
Fixed measurement discrepancies when parent elements have borders

@unwiredben unwiredben merged commit 53d4988 into enyojs:master Dec 14, 2012

Contributor

unwiredben commented Dec 14, 2012

Reviewed-By: Ben Combee (ben.combee@palm.com)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment