added input blur and helpful docs #238

Merged
merged 2 commits into from Mar 28, 2013

Conversation

Projects
None yet
2 participants
Contributor

dgreisen commented Feb 27, 2013

Added input.blur(). Added doc strings for Input.focus and input.blur.

Enyo-DCO-1.1-Signed-off-by: David Greisen dgreisen@gmail.com

Contributor

unwiredben commented Feb 28, 2013

Since blur() and focus() are actually specified in the DOM as part of the HTMLElement interface (http://www.whatwg.org/specs/web-apps/current-work/multipage/elements.html#htmlelement), it would make more sense to push this down to enyo.Control.

Contributor

dgreisen commented Feb 28, 2013

Would you like me to do this? Just to clarify: That will entail me removing
the already-existing input.focus() and inserting an identical
Control.focus().

I am happy to do this. I was just trying to make the minimum changes
necessary in this push.

It seems hasFocus should likewise be moved to Control?

On Thu, Feb 28, 2013 at 4:12 PM, Ben Combee notifications@github.comwrote:

Since blur() and focus() are actually specified in the DOM as part of the
HTMLElement interface (
http://www.whatwg.org/specs/web-apps/current-work/multipage/elements.html#htmlelement),
it would make more sense to push this down to enyo.Control.


Reply to this email directly or view it on GitHubhttps://github.com/enyojs/enyo/pull/238#issuecomment-14257845
.

Contributor

unwiredben commented Feb 28, 2013

Yep, that's exactly what I wanted to see. I'll check against a few internal tests to see if this conflicts and should be able to merge tonight.

Contributor

unwiredben commented Mar 4, 2013

on my list to merge, but pending the MVC branch merge that's happening this week

@unwiredben unwiredben added a commit that referenced this pull request Mar 28, 2013

@unwiredben unwiredben Merge pull request #238 from dgreisen/blur
added input blur and helpful docs

Reviewed-By: Ben Combee (ben.combee@lge.com)
d262ee4

@unwiredben unwiredben merged commit d262ee4 into enyojs:master Mar 28, 2013

Contributor

unwiredben commented Mar 28, 2013

Sorry this took so long to merge in.

Contributor

dgreisen commented Mar 28, 2013

np. You guy's have been busy

On Thu, Mar 28, 2013 at 1:14 PM, Ben Combee notifications@github.comwrote:

Sorry this took so long to merge in.


Reply to this email directly or view it on GitHubhttps://github.com/enyojs/enyo/pull/238#issuecomment-15601380
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment