Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enyo.Model.parse() should work #944

Closed
wants to merge 2 commits into from
Closed

enyo.Model.parse() should work #944

wants to merge 2 commits into from

Conversation

@kurthong
Copy link

kurthong commented Nov 26, 2014

enyo.Model.parse() should work when fetch data from DataSource as mentioned in doc.
Enyo-DCO-1.1-Signed-off-by: Kurt Hong kurt@kurt.pe.kr

// ensure we have an options hash and it knows it was just fetched
opts = opts ? opts : {};
opts = opts? enyo.mixin({}, [this.options, opts]): this.options;

This comment has been minimized.

Copy link
@ryanjduffy

ryanjduffy Dec 12, 2014

Member

This line a duplicate of L789. Let's drop it and the preceding comment.

@kurthong

This comment has been minimized.

Copy link
Owner Author

kurthong commented on 25bc5b0 Dec 15, 2014

@ryanjduffy, thank you for your review, you were right. I fixed that following your comment.

@ryanjduffy ryanjduffy mentioned this pull request Dec 15, 2014
@ryanjduffy

This comment has been minimized.

Copy link
Member

ryanjduffy commented Dec 15, 2014

@kurthong Wanted to add a test for this and do some clean up of enyo.Model while I was in it so I pulled your fix into a new branch and am going to merge it (via PR #965). Thanks for the fix!

@ryanjduffy ryanjduffy closed this Dec 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.