GF-36953:Contextual Popup is bleeds off the screen #62

Merged
merged 1 commit into from Oct 29, 2013

Conversation

Projects
None yet
2 participants
Contributor

gouniLee commented Oct 29, 2013

in regards http://jira2.lgsvl.com/browse/GF-36953

I've modified some calculation codes in ContextualLayout.js In this case, I think it doesn't need to minus activator's height. In order to fit popup's pointing nubs, I've modified moonstone too.(enyojs/moonstone#715)

I think, popup pointing nubs's location should be calculated depends on activators and popup's size. Every case is fixed for now in css.

Enyo-DCO-1.1-Signed-off-by: Goun Lee goun.lee@lge.com

GF-36953:Contextual Popup is bleeds off the screen
Enyo-DCO-1.1-Signed-off-by: Goun Lee <goun.lee@lge.com>

@gouniLee gouniLee referenced this pull request in enyojs/moonstone Oct 29, 2013

Closed

GF:36953:Contextual Popup is bleeds off the screen #715

kevinpschaaf pushed a commit that referenced this pull request Oct 29, 2013

Merge pull request #62 from enyojs/GF-36953-gounlee
GF-36953:Contextual Popup is bleeds off the screen

@kevinpschaaf kevinpschaaf merged commit f634449 into master Oct 29, 2013

1 check passed

default The Travis CI build passed
Details

@kevinpschaaf kevinpschaaf deleted the GF-36953-gounlee branch Oct 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment