Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active particles #57

Merged
merged 8 commits into from Jun 12, 2019

Conversation

@fearmayo
Copy link
Contributor

commented Apr 17, 2019

Huge PR for the active particles machinery. The bulk of the original Active Particle machinery was developed by Nathan et al. I've tested it pretty robustly and it works well as far as I see.
There are some decisions to be made around the IO but at this stage the code is at least ready for review. I will add documentation and some additional tests in due course.

@brittonsmith

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

@fearmayo, when you have a chance, could you merge this with the latest changes from the master branch? We've now got the test suite running there, so it would be good to see if this PR is passing all those tests.

@bwoshea bwoshea assigned ibutsky and DeovratPrasad and unassigned ibutsky Jun 10, 2019

Show resolved Hide resolved src/enzo/hydro_rk/EOS.h Outdated
Show resolved Hide resolved src/enzo/hydro_rk/EOS.h Outdated
Show resolved Hide resolved src/enzo/bondi_alpha.C Outdated
Show resolved Hide resolved src/enzo/ActiveParticle.C Outdated
Show resolved Hide resolved src/enzo/FofLib.C
@jwise77

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

Okay, I've helped out @fearmayo to address all of the issues from the code review. I'm approving.

@jwise77 jwise77 merged commit 8557ed7 into enzo-project:master Jun 12, 2019

2 checks passed

ci/circleci: docs-build Your tests passed on CircleCI!
Details
ci/circleci: test-suite Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.