Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active particles #57

Merged
merged 8 commits into from Jun 12, 2019
Merged

Active particles #57

merged 8 commits into from Jun 12, 2019

Conversation

@fearmayo
Copy link
Contributor

@fearmayo fearmayo commented Apr 17, 2019

Huge PR for the active particles machinery. The bulk of the original Active Particle machinery was developed by Nathan et al. I've tested it pretty robustly and it works well as far as I see.
There are some decisions to be made around the IO but at this stage the code is at least ready for review. I will add documentation and some additional tests in due course.

@brittonsmith
Copy link
Contributor

@brittonsmith brittonsmith commented May 24, 2019

@fearmayo, when you have a chance, could you merge this with the latest changes from the master branch? We've now got the test suite running there, so it would be good to see if this PR is passing all those tests.

Loading

@bwoshea bwoshea assigned ibutsky and DeovratPrasad and unassigned ibutsky Jun 10, 2019
src/enzo/phys_constants.h Show resolved Hide resolved
Loading
src/enzo/hydro_rk/EOS.h Outdated Show resolved Hide resolved
Loading
src/enzo/hydro_rk/EOS.h Outdated Show resolved Hide resolved
Loading
src/enzo/hydro_rk/EOS.h Show resolved Hide resolved
Loading
src/enzo/bondi_alpha.C Outdated Show resolved Hide resolved
Loading
src/enzo/ActiveParticle.h Show resolved Hide resolved
Loading
src/enzo/ActiveParticle.h Show resolved Hide resolved
Loading
src/enzo/RebuildHierarchy.C Show resolved Hide resolved
Loading
src/enzo/New_Grid_ReadGrid.C Show resolved Hide resolved
Loading
src/enzo/ActiveParticleRoutines.C Outdated Show resolved Hide resolved
Loading
@fearmayo
Copy link
Contributor Author

@fearmayo fearmayo commented Jun 11, 2019

@fearmayo, when you have a chance, could you merge this with the latest changes from the master branch? We've now got the test suite running there, so it would be good to see if this PR is passing all those tests.
@brittonsmith Yes - I meant to do this. Is the best thing to do the merge on Github or best to do it on command line? Will the code comments be preserved after a merge?

Loading

src/enzo/DetermineSEDParameters.C Outdated Show resolved Hide resolved
Loading
src/enzo/ActiveParticle_SpringelHernquist.C Outdated Show resolved Hide resolved
Loading
src/enzo/DetermineSEDParameters.C Outdated Show resolved Hide resolved
Loading
src/enzo/ActiveParticle_SmartStar.C Outdated Show resolved Hide resolved
Loading
src/enzo/ActiveParticle_Skeleton.C Outdated Show resolved Hide resolved
Loading
src/enzo/ActiveParticle.C Outdated Show resolved Hide resolved
Loading
src/enzo/FofLib.C Show resolved Hide resolved
Loading
@jwise77
Copy link
Contributor

@jwise77 jwise77 commented Jun 12, 2019

Okay, I've helped out @fearmayo to address all of the issues from the code review. I'm approving.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants