Conversation
Contributor
|
@fearmayo, when you have a chance, could you merge this with the latest changes from the master branch? We've now got the test suite running there, so it would be good to see if this PR is passing all those tests. |
ibutsky
reviewed
Jun 10, 2019
ibutsky
reviewed
Jun 10, 2019
ibutsky
reviewed
Jun 10, 2019
ibutsky
reviewed
Jun 10, 2019
ibutsky
reviewed
Jun 10, 2019
ibutsky
reviewed
Jun 10, 2019
ibutsky
reviewed
Jun 10, 2019
ibutsky
reviewed
Jun 10, 2019
ibutsky
reviewed
Jun 10, 2019
Contributor
Author
|
ibutsky
reviewed
Jun 11, 2019
ibutsky
reviewed
Jun 11, 2019
ibutsky
reviewed
Jun 11, 2019
ibutsky
reviewed
Jun 11, 2019
ibutsky
reviewed
Jun 11, 2019
ibutsky
reviewed
Jun 11, 2019
ibutsky
reviewed
Jun 11, 2019
ibutsky
reviewed
Jun 11, 2019
ibutsky
reviewed
Jun 11, 2019
Contributor
|
Okay, I've helped out @fearmayo to address all of the issues from the code review. I'm approving. |
jwise77
approved these changes
Jun 12, 2019
ibutsky
approved these changes
Jun 12, 2019
This was referenced Jun 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Huge PR for the active particles machinery. The bulk of the original Active Particle machinery was developed by Nathan et al. I've tested it pretty robustly and it works well as far as I see.
There are some decisions to be made around the IO but at this stage the code is at least ready for review. I will add documentation and some additional tests in due course.