Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Three small bugfixes (updated from fixes) #58

Merged
merged 6 commits into from Jun 10, 2019

Conversation

@bwoshea
Copy link
Contributor

commented Apr 25, 2019

This PR contains three small bugfixes:

  1. Tweaked the Makefile to stop saying 'Mercurial' at the end of an Enzo compilation, and instead it says 'Git'. (This is admittedly cosmetic, but also misleading.)

  2. Modifications to ReadAllData.C and Group_ReadAllData.C so that the code fails using my_exit() when one or more MPI tasks has problems reading the boundary condition files, rather than trying to do something clever with regenerating boundary conditions. This has become problematic on Pleiades, which seems to have some issues with unreliable filesystems, and the current setup was causing the code to quietly hang (and waste a lot of computer time), but not crash.

  3. The file Grid_AddMagneticSupernovaeToList.C was setting MassUnits to float (i.e., float or double in Enzo's internal system) when it should always be double, which was causing problems during compilation with 32-bit floating point precision.

@bwoshea bwoshea changed the title Two small bugfixes Three small bugfixes (updated from fixes) Apr 27, 2019

@dcollins4096 dcollins4096 self-assigned this Jun 10, 2019

@jwise77 jwise77 merged commit 158f6af into enzo-project:master Jun 10, 2019

1 of 2 checks passed

ci/circleci: test-suite Your tests failed on CircleCI
Details
ci/circleci: docs-build Your tests passed on CircleCI!
Details

@bwoshea bwoshea deleted the bwoshea:bugfixes branch Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.