Three small bugfixes (updated from fixes) #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ist.C's compilation when using 32-bit precision
kohdaegene
approved these changes
Jun 10, 2019
jwise77
approved these changes
Jun 10, 2019
dcollins4096
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains three small bugfixes:
Tweaked the Makefile to stop saying 'Mercurial' at the end of an Enzo compilation, and instead it says 'Git'. (This is admittedly cosmetic, but also misleading.)
Modifications to ReadAllData.C and Group_ReadAllData.C so that the code fails using my_exit() when one or more MPI tasks has problems reading the boundary condition files, rather than trying to do something clever with regenerating boundary conditions. This has become problematic on Pleiades, which seems to have some issues with unreliable filesystems, and the current setup was causing the code to quietly hang (and waste a lot of computer time), but not crash.
The file Grid_AddMagneticSupernovaeToList.C was setting MassUnits to float (i.e., float or double in Enzo's internal system) when it should always be double, which was causing problems during compilation with 32-bit floating point precision.