Added functionality: new types of moving refinement regions #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bwoshea, the automated testing stuff has now been merged into the main repo. If you can merge those changes and update the PR, the test suite will run. |
aemerick
reviewed
Jun 10, 2019
aemerick
reviewed
Jun 10, 2019
|
PR looks good overall. Just had a couple minor comments / questions. |
src/enzo/SetEvolveRefineRegion.C
Outdated
| that EvolveMustRefineRegionTime[0] is the earliest time and the last output is the latest time (for | ||
| the given track file). */ | ||
| if(time < EvolveMustRefineRegionTime[0] || time > EvolveMustRefineRegionTime[EvolveMustRefineRegionNtimes-1]){ | ||
| fprintf(stderr,"SetEvolveRefineRegion ERROR for EvolveMustRefineRegion: current simulation time is outside of range of track file redshifts!"); |
There was a problem hiding this comment.
Suggested change
| fprintf(stderr,"SetEvolveRefineRegion ERROR for EvolveMustRefineRegion: current simulation time is outside of range of track file redshifts!"); | |
| fprintf(stderr,"SetEvolveRefineRegion ERROR for EvolveMustRefineRegion: current simulation time is outside of range of track file times!"); |
src/enzo/SetEvolveRefineRegion.C
Outdated
| that EvolveRefineRegionTime[0] is the earliest time and the last output is the latest time (for | ||
| the given track file). */ | ||
| if(time < EvolveCoolingRefineRegionTime[0] || time > EvolveCoolingRefineRegionTime[EvolveCoolingRefineRegionNtimes-1]){ | ||
| fprintf(stderr,"SetEvolveRefineRegion ERROR: current simulation redshift is outside of range of track file redshifts! (Cooling time box)"); |
There was a problem hiding this comment.
Suggested change
| fprintf(stderr,"SetEvolveRefineRegion ERROR: current simulation redshift is outside of range of track file redshifts! (Cooling time box)"); | |
| fprintf(stderr,"SetEvolveRefineRegion ERROR: current simulation time is outside of range of track file times! (Cooling time box)"); |
aemerick
approved these changes
Jun 10, 2019
cbrummelsmith
approved these changes
Jun 10, 2019
kohdaegene
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands Enzo's capabilities by adding two main types of functionality and fixes one bug. The new functionality is:
It expands the functionality of the MustRefineRegion code (which forces a rectilinear portion of a simulation to be refined to at least a user-determined minimum level) so that the user can have a MustRefineRegion whose bounds and minimum level of refinement vary over time/redshift. This information is specified by a user-supplied data file providing the time/redshift evolution of the MustRefineRegion parameters, and linearly interpolates between entries in this file.
It adds a CoolingRefineRegion option. This allows the user to specify a rectilinear sub-volume of a simulation in which refinement based on the cooling time can take place, and also vary that over time if desired in the same manner as described above. The ability to constrain cooling time-based refinement to a subvolume is particularly desirable because in certain environments refinement based on the cooling time can cause an excessive amount of mesh creation, which can cause out-of-memory errors and generally be very computationally expensive.
In addition to these new features, the original moving RefinementRegion code (which just constrains refinement to be in a subvolume, but does not force refinement or restrict it to a specific type of refinement) now linearly interpolates between times in the same manner as the two new moving RefinementRegion.
All of the moving refinement region options now do error checking - if the current simulation time is before or after the times listed in the entries in the user-supplied RefineRegion file, Enzo gives an error message and exits. This is a highly desirable behavior, because otherwise the refinement region would stay stationary and not give any warnings.