Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excised libconfig from Enzo #67

Merged
merged 1 commit into from Jun 10, 2019

Conversation

@bwoshea
Copy link
Contributor

commented Jun 10, 2019

This PR removes libconfig from Enzo. Libconfig was put into Enzo in 2011 by @matthewturk (PRs 62f8cca, b5392e0, 2df6c95, 479c3ff in Jan. 2011, May 2011, and Aug. 2011), and has not been used since then. Users are reporting that its presence is causing problems with compilation on OS X (and possibly other places).

@kohdaegene kohdaegene self-requested a review Jun 10, 2019

@dcollins4096 dcollins4096 self-assigned this Jun 10, 2019

@dcollins4096
Copy link
Contributor

left a comment

This causes problems on some Ubuntu use cases as well.

@jwise77 jwise77 merged commit 4aeac0a into enzo-project:master Jun 10, 2019

@bwoshea bwoshea deleted the bwoshea:libconfig_must_die branch Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.