Excised libconfig from Enzo#67
Merged
jwise77 merged 1 commit intoenzo-project:masterfrom Jun 10, 2019
Merged
Conversation
kohdaegene
approved these changes
Jun 10, 2019
jwise77
approved these changes
Jun 10, 2019
dcollins4096
approved these changes
Jun 10, 2019
Contributor
dcollins4096
left a comment
dcollins4096
left a comment
There was a problem hiding this comment.
This causes problems on some Ubuntu use cases as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes libconfig from Enzo. Libconfig was put into Enzo in 2011 by @matthewturk (PRs 62f8cca, b5392e0, 2df6c95, 479c3ff in Jan. 2011, May 2011, and Aug. 2011), and has not been used since then. Users are reporting that its presence is causing problems with compilation on OS X (and possibly other places).