Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small tweak to hierarchy file reader - patch for pre-AP simulations #80

Merged
merged 3 commits into from
Jun 17, 2019

Conversation

bwoshea
Copy link
Contributor

@bwoshea bwoshea commented Jun 17, 2019

This is described by the discussion in Issue #79 , and implements the fix described there. It fixes a bug where the recently-accepted active particle PR (PR #57 ) breaks restarts from simulations that have particles but predate the active particle PR merge (which is to say, almost all Enzo simulations ever).

Copy link
Contributor

@brittonsmith brittonsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this whole block can be refactored to be a bit more straightforward. At minimum, the train of comments here is pretty difficult to follow. Perhaps it could be simplified to something like, "If NumberOfActiveParticles line appears, the next two lines need to be read in but are currently unused."

src/enzo/New_Grid_ReadGrid.C Outdated Show resolved Hide resolved
bwoshea and others added 2 commits June 17, 2019 12:28
@bwoshea
Copy link
Contributor Author

bwoshea commented Jun 17, 2019

Followup: I just pushed some changes to clean up the code, following @brittonsmith 's suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants