Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small tweak to hierarchy file reader - patch for pre-AP simulations #80

Merged
merged 3 commits into from Jun 17, 2019

Conversation

@bwoshea
Copy link
Contributor

commented Jun 17, 2019

This is described by the discussion in Issue #79 , and implements the fix described there. It fixes a bug where the recently-accepted active particle PR (PR #57 ) breaks restarts from simulations that have particles but predate the active particle PR merge (which is to say, almost all Enzo simulations ever).

@fearmayo fearmayo self-requested a review Jun 17, 2019

@brittonsmith
Copy link
Contributor

left a comment

I think this whole block can be refactored to be a bit more straightforward. At minimum, the train of comments here is pretty difficult to follow. Perhaps it could be simplified to something like, "If NumberOfActiveParticles line appears, the next two lines need to be read in but are currently unused."

Show resolved Hide resolved src/enzo/New_Grid_ReadGrid.C Outdated

bwoshea and others added some commits Jun 17, 2019

Update src/enzo/New_Grid_ReadGrid.C
Co-Authored-By: Britton Smith <brittonsmith@gmail.com>
@bwoshea

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

Followup: I just pushed some changes to clean up the code, following @brittonsmith 's suggestion.

@jwise77 jwise77 merged commit 9ec8390 into enzo-project:master Jun 17, 2019

2 checks passed

ci/circleci: docs-build Your tests passed on CircleCI!
Details
ci/circleci: test-suite Your tests passed on CircleCI!
Details

@bwoshea bwoshea deleted the bwoshea:ap_fix branch Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.