Fixes to map RadiationRedshift* parameters to Grackle #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwise77
approved these changes
Jun 18, 2019
bwoshea
approved these changes
Jun 18, 2019
fearmayo
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix to make Enzo to be fully functional with all of Grackle’s features. (Previously these four Enzo parameters were not mapped to their respective Grackle parameters.) This fix -- identified by myself (Ji-hoon) and Britton -- will also make Enzo to be fully compatible with other codes in the AGORA comparison test suites of cosmological runs.
(FYI, the only other place where RadiationRedshift* parameters are used is in Enzo is RadiationFieldCalculateRates.C. This file is not used anyway if RadiationFieldType = 0 -- which is often the case when Grackle is employed for cooling/radiation calculations.)