Adding active particle docs#85
Conversation
| AP type none of the implementations have been (robustly) tested. | ||
|
|
||
| * SmartStar | ||
| * Accreting Particle |
There was a problem hiding this comment.
This is a comment related to the Enzo code file not the documentation. In the file 'ActiveParticle_AccretingParticle.h' and 'ActiveParticle_SmartStar.h' there is a template class 'DepositMass' defined. One of the argument for this class is 'GalaxyParticleID' in both which I guess is an error getting carried over due to using the modified 'ActiveParticle_GalaxyParticle.h' for these two cases.
There was a problem hiding this comment.
OK. That should be a separate PR though. Can you raise an issue on it or open a PR?
|
i realized that there might be some minimal conflicts with PR#83 which was just merged, where i had created some filler headings for active particles. other than that, this looks good to go. this PR should take precedence |
bwoshea
left a comment
bwoshea
left a comment
There was a problem hiding this comment.
I'm happy to approve this as-is. I think it could possibly be expanded a bit, but as we use the active particles more it'll become more clear what's needed! :-)
|
Looks good to me! We need a third approve here. |
brittonsmith
left a comment
brittonsmith
left a comment
There was a problem hiding this comment.
I've marked some typos and suggestions that turn URLs into hyperlinks. I think you can accept these right on this page instead of implementing them by hand.
|
Hi @fearmayo, can you review and accept @brittonsmith's suggested changes? Britton can approve when he's ready, and then I'll merge. This is the last substantial PR before the release! |
Accepting suggestions made by Britton Co-Authored-By: Britton Smith <brittonsmith@gmail.com>
I think that should be done now. I accepted the changes and I can see the commit. |
6 participants
I'v e started to add/update the AP framework sections.