Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding active particle docs #85

Merged
merged 9 commits into from Jul 9, 2019

Conversation

@fearmayo
Copy link
Contributor

commented Jun 24, 2019

I'v e started to add/update the AP framework sections.

@fearmayo fearmayo requested review from bwoshea and kohdaegene Jun 24, 2019

@fearmayo fearmayo requested a review from DeovratPrasad Jun 25, 2019

AP type none of the implementations have been (robustly) tested.

* SmartStar
* Accreting Particle

This comment has been minimized.

Copy link
@DeovratPrasad

DeovratPrasad Jul 2, 2019

This is a comment related to the Enzo code file not the documentation. In the file 'ActiveParticle_AccretingParticle.h' and 'ActiveParticle_SmartStar.h' there is a template class 'DepositMass' defined. One of the argument for this class is 'GalaxyParticleID' in both which I guess is an error getting carried over due to using the modified 'ActiveParticle_GalaxyParticle.h' for these two cases.

This comment has been minimized.

Copy link
@fearmayo

fearmayo Jul 2, 2019

Author Contributor

OK. That should be a separate PR though. Can you raise an issue on it or open a PR?

@bwoshea bwoshea referenced this pull request Jul 3, 2019

Merged

fuzzy dark matter (revised) #82

@kohdaegene

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

i realized that there might be some minimal conflicts with PR#83 which was just merged, where i had created some filler headings for active particles. other than that, this looks good to go. this PR should take precedence

@bwoshea

bwoshea approved these changes Jul 3, 2019

Copy link
Contributor

left a comment

I'm happy to approve this as-is. I think it could possibly be expanded a bit, but as we use the active particles more it'll become more clear what's needed! :-)

@bwoshea

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

Looks good to me! We need a third approve here.

@brittonsmith
Copy link
Contributor

left a comment

I've marked some typos and suggestions that turn URLs into hyperlinks. I think you can accept these right on this page instead of implementing them by hand.

Show resolved Hide resolved doc/manual/source/parameters/index.rst Outdated
Show resolved Hide resolved doc/manual/source/parameters/index.rst Outdated
Show resolved Hide resolved doc/manual/source/parameters/index.rst Outdated
Show resolved Hide resolved doc/manual/source/physics/star_particles.rst Outdated
Show resolved Hide resolved doc/manual/source/parameters/index.rst Outdated
Show resolved Hide resolved doc/manual/source/parameters/index.rst Outdated
Show resolved Hide resolved doc/manual/source/parameters/index.rst Outdated
Show resolved Hide resolved doc/manual/source/parameters/index.rst Outdated
Show resolved Hide resolved doc/manual/source/physics/active_particles.rst Outdated
Show resolved Hide resolved doc/manual/source/physics/active_particles.rst Outdated
@brittonsmith
Copy link
Contributor

left a comment

I didn't have permissions to apply these myself, but I'm happy to do so.

@jwise77

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

Hi @fearmayo, can you review and accept @brittonsmith's suggested changes? Britton can approve when he's ready, and then I'll merge. This is the last substantial PR before the release!

Apply suggestions from code review
Accepting suggestions made by Britton

Co-Authored-By: Britton Smith <brittonsmith@gmail.com>
@fearmayo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

Hi @fearmayo, can you review and accept @brittonsmith's suggested changes? Britton can approve when he's ready, and then I'll merge. This is the last substantial PR before the release!

I think that should be done now. I accepted the changes and I can see the commit.

@brittonsmith
Copy link
Contributor

left a comment

All good by me.

@jwise77 jwise77 merged commit a37978f into enzo-project:master Jul 9, 2019

2 checks passed

ci/circleci: docs-build Your tests passed on CircleCI!
Details
ci/circleci: test-suite Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.