Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDRip Ripper Component still reads as v2.3 #132

Closed
Peppernrino opened this issue Jul 11, 2020 · 3 comments
Closed

CDRip Ripper Component still reads as v2.3 #132

Peppernrino opened this issue Jul 11, 2020 · 3 comments
Labels

Comments

@Peppernrino
Copy link

Describe the bug
In the release notes for 1.1.2, it's stated that the CDRip component was updated to v2.4, but it says CDRip Component is v2.3 when a CD is extracting audio, as well as in the logs.

To Reproduce
Steps to reproduce the behavior:

  1. extract CD audio
  2. observe "Decoder" window while extracting/inspect conversion log
  3. log states: Decoder: CDRip Ripper Component v2.3

Expected behavior
I expected it to say v2.4.

Screenshots
If applicable, add screenshots to help explain your problem.
image
The picture is from version 1.1.2a, but it is still relevant in v1.1.2b.

System (please complete the following information)

  • OS: Windows 8.1
  • CPU: Ryzen 1600X
  • RAM: 16GB
@enzo1982
Copy link
Owner

My bad. I forgot to increment the version number reported by the GetCDRipVersion call when updating the library. The version shipped with fre:ac 1.1.2 is 2.4, despite the wrong display.

Also, the only change from 2.3 to 2.4 is fixing a crash that would occur on some systems when loading the library. In that case, the CD ripping features would not be available in fre:ac despite a CD drive possibly being present. If CD ripping is available to you in fre:ac, you are not affected by that bug.

@Peppernrino
Copy link
Author

All good. I had a note about something like that in the additional comments... but I deleted it. lol

@enzo1982
Copy link
Owner

Fixed in fre:ac 1.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants