Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add new question about the tests to the GitHub template #45

Merged
merged 1 commit into from Feb 19, 2023

Conversation

neuodev
Copy link
Contributor

@neuodev neuodev commented Feb 19, 2023

Please explain the main changes of your pull request

Whenever a new returned code is added, new unit tests should be written/updated to cover the new case.
I added a checklist item to remind who is opening the PR to add/update the tests.

Checklist

  • Have you added any new returned codes to the README file?

@enzoferey
Copy link
Owner

Hey @AhmedIbrahim336, thanks for the PR !

Just for your information 100% test coverage is enforced via the CI, so we will not miss any tests for sure. But I'm happy to add it to the list 👍🏻

@codecov-commenter
Copy link

Codecov Report

Merging #45 (0a83a0f) into main (d4e452b) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##              main       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          666       666           
  Branches        79        79           
=========================================
  Hits           666       666           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@enzoferey enzoferey changed the title chore: add new question about the tests to the GitHub template core: add new question about the tests to the GitHub template Feb 19, 2023
@enzoferey enzoferey merged commit f9dc429 into enzoferey:main Feb 19, 2023
3 checks passed
@neuodev neuodev deleted the github-pr-template branch March 25, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants