Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React hooks support checklist #2011

Open
12 of 14 tasks
chenesan opened this issue Feb 8, 2019 · 55 comments
Open
12 of 14 tasks

React hooks support checklist #2011

chenesan opened this issue Feb 8, 2019 · 55 comments
Projects

Comments

@chenesan
Copy link
Contributor

@chenesan chenesan commented Feb 8, 2019

Sorry for removing issue template. Since the React 16.8 is out we can start to work on hooks support in enzyme now. Previously I tried to open PR in #2008 to help with this but found out that there are too many apis in React hooks. After some thinking I feel it's better to track all of the supports / PR in one issues, and create one PR for each hooks api (useState, useEffect, etc).

known issues (some are resolved with newer version of react):

  • setState returned from useState not works with shallow before react@16.8.5 . Fixed in facebook/react#15120 .
  • useEffect and useLayoutEffect not works with shallow because react shallow renderer doesn't run it. (facebook/react#15275)
  • useCallback doesn't memoize callback in react shallow renderer (facebook/react#15774)

Currently I'm working in useState (#2008) and I'm glad to see if anyone else would like to help to support other apis. For now we need to add many tests to make sure what is working in enzyme, and what is not, then add patch / feature into it. I can help to maintain the above checklist if there are any related issues / PR .

I'm simply volunteer to do this and not a main maintainer here though so @ljharb if you have had any plan / schedule on this feel free to tell me and I can change or close this :-)

@k3ithl1m
Copy link
Contributor

@k3ithl1m k3ithl1m commented Mar 3, 2019

Thanks for making this list @chenesan!
@ljharb, I'm interested in tackling some of this features too. It might take me some time to finish implementing it as I'm getting a little busy in the next two weeks, but I am very interested in helping out.
I've currently worked on two test cases #2029

If no one has took up the useEffect feature. I would like to try that out!

Loading

@chenesan
Copy link
Contributor Author

@chenesan chenesan commented Mar 6, 2019

Hi @k3ithl1m glad to see your work :) FYI I just open #2034 to wrap render function of mount renderer with act(). That should be related to useEffect test cases and I hope that help!

Loading

@venikx
Copy link

@venikx venikx commented Mar 7, 2019

@chenesan Also note that React seemed to have an issue with shallow rendering hooks right now. Not sure if it was addressed by the React time already or not.

Loading

@nixstrom
Copy link

@nixstrom nixstrom commented Mar 7, 2019

@AnaRobynn Didn't they solve this with facebook/react#14567 ?

Loading

@venikx
Copy link

@venikx venikx commented Mar 7, 2019

@nixstrom It’s supported, but there are issues apparantly. I saw Dan tweeting about it yesterday: https://twitter.com/dan_abramov/status/1103304963445403648?s=21

Loading

@chenesan
Copy link
Contributor Author

@chenesan chenesan commented Mar 7, 2019

I think the issue should be facebook/#14841, which #2008 would depends on.

Loading

@pgangwani
Copy link

@pgangwani pgangwani commented Mar 9, 2019

@chenesan @k3ithl1m : Added test cases #2041 for useEffect, useState & custom hooks along with combination of those. Will add few more soon. I was thinking to get some support as a focus (micro) team for react hooks test cases considering all scnerios.

Loading

@pgangwani
Copy link

@pgangwani pgangwani commented Mar 10, 2019

@chenesan : Please add #2041 in custom hooks checklist item as I added test case in that PR

Loading

@pgangwani
Copy link

@pgangwani pgangwani commented Mar 10, 2019

@ljharb @chenesan : Simple hooks testing is successful in mount rendering without act :)
Example: https://codesandbox.io/s/5xkjk1ql14

Loading

@chenesan
Copy link
Contributor Author

@chenesan chenesan commented Mar 11, 2019

@pgangwani I believe the test could pass without act. However when it comes to setting state in useEffect without act wrapping and assert the state changes after mount (like test case of #2034 ), it would fail. Since #2034 is merged this should be fine to mount render without act(), though.

Loading

@pgangwani
Copy link

@pgangwani pgangwani commented Mar 11, 2019

Loading

@chenesan
Copy link
Contributor Author

@chenesan chenesan commented Mar 11, 2019

I'm not sure if that would pass without act wrap. but since we wrap mount with act in master now, this should be fine I think.

Loading

@pgangwani
Copy link

@pgangwani pgangwani commented Mar 11, 2019

Loading

@pgangwani
Copy link

@pgangwani pgangwani commented Mar 18, 2019

@chenesan : [Update]: Added test cases for useReducer & useContext. Few custom hooks too

Loading

@tlginn
Copy link

@tlginn tlginn commented Apr 11, 2019

Are there any updates on when useMemo will be supported with shallow rendering?

Specifically I'm rendering a connected react-redux component. Since react-redux is now relying on hooks, I'm getting the "Invalid hook call" when it attempts to call useMemo.

I can workaround using mount for now, but would prefer to keep all of my tests using shallow.

Loading

@ljharb
Copy link
Member

@ljharb ljharb commented Apr 12, 2019

@tlginn in the next release of enzyme, hopefully.

Loading

@charesbast
Copy link

@charesbast charesbast commented Sep 20, 2019

Any news on releasing a version with partial hooks support ? latest release is from 10 Jun... 😢

Loading

@skyboyer
Copy link
Contributor

@skyboyer skyboyer commented Sep 20, 2019

Any news on releasing a version with partial hooks support ? latest release is from 10 Jun... 😢

believe it's blocked by facebook/react#15275

Loading

@dschinkel
Copy link

@dschinkel dschinkel commented Oct 15, 2019

Is it safe to say that Enzyme Shallow still doesn't work on React Hooks?

Loading

@ljharb
Copy link
Member

@ljharb ljharb commented Oct 15, 2019

@dschinkel no, because that suggests zero support - neither does it have full support.

Loading

TimGuiteDiamond added a commit to dls-controls/cs-web-proto that referenced this issue Dec 12, 2019
This is an ongoing issue with shallow wrapping and the useEffect hook unfortunately! See enzymejs/enzyme#2011
@manveers96
Copy link

@manveers96 manveers96 commented Feb 5, 2020

I'm facing issues with .dive() method after upgrading to styled-components v5.0.0 and jest-styled-components v7.0.0 and it was working fine earlier before the upgrade.
The issue I'm facing is related to Hooks:

Invariant Violation: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
    1. You might have mismatching versions of React and the renderer (such as React DOM)
    2. You might be breaking the Rules of Hooks
    3. You might have more than one copy of React in the same app
    See https://fb.me/react-invalid-hook-call for tips about how to debug and fix this problem.

Do we not have support for hooks with .dive()? Any help would be appreciated @chenesan @ljharb

Loading

@ljharb
Copy link
Member

@ljharb ljharb commented Feb 5, 2020

As far as I'm aware, they should work the same in .dive() as they do in shallow(), since that's all it does.

Loading

@manveers96
Copy link

@manveers96 manveers96 commented Feb 6, 2020

@ljharb Correction - I'm facing issues with .dive() as well as .shallow() after upgrading to styled-components v5.0.0 and jest-styled-components v7.0.0.
Anyone else facing similar issue?
Any suggestions how to fix this?

Loading

@ljharb
Copy link
Member

@ljharb ljharb commented Feb 6, 2020

What changed in the underlying implementation in v5 versus v4?

Loading

@manveers96
Copy link

@manveers96 manveers96 commented Feb 6, 2020

@ljharb As per the styled components changelog (https://github.com/styled-components/styled-components/blob/master/CHANGELOG.md#v500---2020-01-13), there seems to be no mention in relation to hooks. I'm not sure of what might be causing the issue.

Loading

@ljharb
Copy link
Member

@ljharb ljharb commented Feb 6, 2020

Clicking on styled-components/styled-components@v4.4.1...v5.0.0, however, shows a commit called "reimplement using hooks", so it's likely that this is the issue.

Loading

@josh08h
Copy link

@josh08h josh08h commented Mar 16, 2020

This PR suggests useState works with the shallow API.. a few of us are seeing that's not the case here. Can someone please clarify?

Loading

@csalvato
Copy link

@csalvato csalvato commented Mar 21, 2020

useEffect (Test case PR #2034 #2041 ; Currently not work in shallow renderer, see facebook/react#15275)

This is currently marked as completed, but I am still getting a console.error when using mount with a useEffect hook.

"enzyme": "^3.11.0",
"react": "^16.13.1",

In my case, useEffect is handling a promise, and then updating the state of the component:

useEffect(() => {
    axios
      .get(`/users/${userId}`)
      .then(response => setFields(response.data.data.attributes))
      .catch(err => console.error('Failed to load user profile', err))
  }, [])

This is the error I get:

  console.error node_modules/react-dom/cjs/react-dom.development.js:88
    Warning: An update to ProfileFeature inside a test was not wrapped in act(...).
    
    When testing, code that causes React state updates should be wrapped into act(...):
    
    act(() => {
      /* fire events that update state */
    });
    /* assert on the output */
    
    This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act
        in ProfileFeature (at ProfileFeature.spec.js:41)
        in Router (at ProfileFeature.spec.js:40)
        in Provider (created by WrapperComponent)
        in WrapperComponent

Is this something on your radar? Or am I doing something incorrectly?

Loading

@jzipfler
Copy link

@jzipfler jzipfler commented Mar 31, 2020

I will post a summary for those that came across this issue because of the problem with shallow renderer in enzyme.

The issue from facebook/react#15275 is not completed as mentioned in the comment above, it was just closed because of facebook/react#17321.

Issue facebook/react#17321 is closed as well, because as a outcome the react-shallow-renderer was extracted so that it is no longer part of the react project so that it can be enhanced/developed independently from the react team.

It seems that the project is now located under https://github.com/NMinhNguyen/react-shallow-renderer.
In addition there is a issue (enzymejs/react-shallow-renderer#16) in this new project, asking to transfer the shallow renderer into the github enzyme org.

Hopefully I summarized that correctly. For more, detailed or maybe more correct information, have a look on the linked issues/projects.

Loading

@dschinkel
Copy link

@dschinkel dschinkel commented Jul 4, 2020

Continuing on @jzipfler 's summary.

The problem still remains that we can't test the public API of a React Hook (custom methods we choose to carefully expose to be part of it) via shallow render. People can't test off instance() which a lot of us do, and found solid ways to do that safely. There's a huge bandwagon of "don't test implementation details" and that is such a vague and misunderstood concept. Testing implementation details is relative to how you're writing your tests and your components and many of us, prefer not to be forced to test always through heavy imperative Shell (DOM wiring and events) just to gain confidence and design feedback especially when we TDD and code very leanly.

The Second problem is we shouldn't have to rely on Jest as a hack to get around shallow shortcomings. I come from a land where mocking everything is a big smell. Mocking Angular via TestBed, enough said. We should be able to test a lib like React with whatever testing framework we want. They keep forcing Jest mocking, etc. I don't wanna keep hearing that I must use Jest.

So for me, we're still forced to test everything through DOM wiring, which is not ideal for shallow. This is still not resolved really.

facebook/react#17321 (comment)

Loading

@dschinkel
Copy link

@dschinkel dschinkel commented Jul 4, 2020

@dschinkel no, because that suggests zero support - neither does it have full support.

@ljharb We really need to know what exactly this means. What is supported, what does not zero actually mean? Is there a checklist that thoroughly explains the what and gaps in the current version of enzyme rather than try to guess here? Can we be a little more detailed here?

I probably won't give up on this until someone finds a way to either push React or work on a way that allows you to truly test under the skin with React Hooks. I personally don't have time to contribute on a whole new repo to do so.

Loading

@danielo515
Copy link

@danielo515 danielo515 commented May 18, 2021

I see many people only mentions shallow. Are hooks supposed to work with mount? If so, what are the requirements? I am getting react errors for almost every test where any of the nested components uses any hook (useEffect, useState, etc).
Are there any guidelines or requirements on how to test components that contain hooks?

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
React 16
  
v16.8+: Hooks
Linked pull requests

Successfully merging a pull request may close this issue.

None yet