From 6e1920564ae8a68e344f22c3d5c37a2243887e13 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Kubitz?= Date: Mon, 4 Dec 2023 17:06:48 +0100 Subject: [PATCH] remove unchecked warnings Depending on the amount of warnings on project the warning has been disabled, Suppressed or solved To get a clean Problems View on ancient code --- .../org/eclipse/e4/ui/internal/LocaleChangeServiceImpl.java | 2 +- .../eclipse/e4/ui/internal/workbench/PartServiceImpl.java | 1 + .../core/DirtyFileSearchParticipantServiceTracker.java | 1 + .../org.eclipse.ui.ide/.settings/org.eclipse.jdt.core.prefs | 2 +- .../eclipse/ui/internal/ide/dialogs/OpenResourceDialog.java | 1 - .../ui/internal/views/markers/ViewerColumnsDialog.java | 6 ------ .../eclipse/ui/internal/views/log/EventDetailsDialog.java | 2 ++ .../views/properties/tabbed/view/TabDescriptor.java | 2 ++ .../properties/tabbed/view/TabbedPropertyRegistry.java | 1 + .../view/TabbedPropertyRegistryClassSectionFilter.java | 1 + .../ui/views/properties/tabbed/AbstractTabDescriptor.java | 1 + .../ui/views/properties/tabbed/TabbedPropertySheetPage.java | 1 + .../.settings/org.eclipse.jdt.core.prefs | 2 +- .../ui/activities/ActivityCategoryPreferencePage.java | 1 - .../Eclipse UI/org/eclipse/ui/commands/AbstractHandler.java | 1 - .../eclipse/ui/databinding/typed/WorkbenchProperties.java | 3 --- .../Eclipse UI/org/eclipse/ui/internal/ShowViewMenu.java | 1 - .../ui/internal/databinding/AdaptedValueProperty.java | 1 - .../ui/internal/databinding/SelectionServiceListener.java | 1 - .../ui/internal/databinding/SingleSelectionProperty.java | 1 - .../ui/internal/dialogs/ContentTypesPreferencePage.java | 1 - .../eclipse/ui/internal/dialogs/ViewsPreferencePage.java | 1 - .../ui/internal/e4/migration/PerspectiveBuilder.java | 1 - .../eclipse/ui/internal/handlers/LegacyHandlerService.java | 3 --- .../org/eclipse/ui/internal/keys/BindingService.java | 1 - .../org/eclipse/ui/internal/registry/EditorRegistry.java | 1 - .../org/eclipse/ui/internal/registry/FileEditorMapping.java | 1 - .../statushandlers/WorkbenchStatusDialogManagerImpl.java | 1 - .../ui/internal/themes/RGBVisibleContrastColorFactory.java | 1 - .../Eclipse UI/org/eclipse/ui/part/PageBookView.java | 1 - .../e4/ui/tests/application/HeadlessApplicationTest.java | 1 + .../org/eclipse/ui/tests/leaks/LeakTests.java | 1 + .../org/eclipse/ui/tests/manual/ViewWithSaveables.java | 1 + .../ui/tests/statushandlers/LabelProviderWrapperTest.java | 2 ++ 34 files changed, 18 insertions(+), 31 deletions(-) diff --git a/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/LocaleChangeServiceImpl.java b/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/LocaleChangeServiceImpl.java index d062693d9e1..07c820e13d1 100644 --- a/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/LocaleChangeServiceImpl.java +++ b/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/LocaleChangeServiceImpl.java @@ -110,7 +110,7 @@ public void changeApplicationLocale(String localeString) { * @param children * The list of {@link MUIElement}s that should be checked for Locale updates. */ - @SuppressWarnings({ "rawtypes" }) + @SuppressWarnings({ "rawtypes", "unchecked" }) protected void updateLocalization(List children) { for (MUIElement element : children) { if (element instanceof MElementContainer) { diff --git a/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/PartServiceImpl.java b/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/PartServiceImpl.java index a9a67b2e7d6..815a8254e1a 100644 --- a/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/PartServiceImpl.java +++ b/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/PartServiceImpl.java @@ -1042,6 +1042,7 @@ private MPart addPart(MPart providedPart, MPart localPart) { addToLastContainer(category, providedPart); } else { // add the part to the container + @SuppressWarnings("unchecked") MElementContainer container = containers.get(0); MPlaceholder placeholder = providedPart.getCurSharedRef(); if (placeholder == null) { diff --git a/bundles/org.eclipse.search.core/search/org/eclipse/search/internal/core/DirtyFileSearchParticipantServiceTracker.java b/bundles/org.eclipse.search.core/search/org/eclipse/search/internal/core/DirtyFileSearchParticipantServiceTracker.java index 53a01b65b07..6ba738f74a7 100644 --- a/bundles/org.eclipse.search.core/search/org/eclipse/search/internal/core/DirtyFileSearchParticipantServiceTracker.java +++ b/bundles/org.eclipse.search.core/search/org/eclipse/search/internal/core/DirtyFileSearchParticipantServiceTracker.java @@ -62,6 +62,7 @@ public int compare(ServiceReference o1, ServiceReference dirtyFiles() { return Collections.EMPTY_MAP; diff --git a/bundles/org.eclipse.ui.ide/.settings/org.eclipse.jdt.core.prefs b/bundles/org.eclipse.ui.ide/.settings/org.eclipse.jdt.core.prefs index 6d14ef0147a..e397b13d0ef 100644 --- a/bundles/org.eclipse.ui.ide/.settings/org.eclipse.jdt.core.prefs +++ b/bundles/org.eclipse.ui.ide/.settings/org.eclipse.jdt.core.prefs @@ -106,7 +106,7 @@ org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore org.eclipse.jdt.core.compiler.problem.terminalDeprecation=warning org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning org.eclipse.jdt.core.compiler.problem.unavoidableGenericTypeProblems=enabled -org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning +org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=ignore org.eclipse.jdt.core.compiler.problem.unclosedCloseable=warning org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=ignore org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning diff --git a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/OpenResourceDialog.java b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/OpenResourceDialog.java index cf27b9fad6c..f164a0687f0 100644 --- a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/OpenResourceDialog.java +++ b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/OpenResourceDialog.java @@ -279,7 +279,6 @@ protected void buttonPressed(int buttonId) { } } - @SuppressWarnings("unchecked") @Override protected void updateButtonsEnableState(IStatus status) { Button okButton = getOkButton(); diff --git a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/ViewerColumnsDialog.java b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/ViewerColumnsDialog.java index a4669caddf6..022478e4c29 100644 --- a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/ViewerColumnsDialog.java +++ b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/ViewerColumnsDialog.java @@ -337,7 +337,6 @@ void handleNonVisibleSelection(ISelection selection) { * columns. Takes care of various enablements. */ void handleVisibleSelection(ISelection selection) { - @SuppressWarnings("unchecked") List selVCols = ((IStructuredSelection) selection).toList(); List allVCols = getVisible(); toNonVisibleBtt.setEnabled(selVCols.size() > 0 && allVCols.size() > selVCols.size()); @@ -388,7 +387,6 @@ void handleVisibleSelection(ISelection selection) { */ void handleDownButton(Event e) { IStructuredSelection selection = visibleViewer.getStructuredSelection(); - @SuppressWarnings("unchecked") List selVCols = selection.toList(); List allVCols = getVisible(); IColumnUpdater updater = doGetColumnUpdater(); @@ -412,7 +410,6 @@ void handleDownButton(Event e) { */ void handleUpButton(Event e) { IStructuredSelection selection = visibleViewer.getStructuredSelection(); - @SuppressWarnings("unchecked") List selVCols = selection.toList(); List allVCols = getVisible(); IColumnUpdater updater = doGetColumnUpdater(); @@ -435,7 +432,6 @@ void handleUpButton(Event e) { */ void handleToVisibleButton(Event e) { IStructuredSelection selection = nonVisibleViewer.getStructuredSelection(); - @SuppressWarnings("unchecked") List selVCols = selection.toList(); getNonVisible().removeAll(selVCols); @@ -465,7 +461,6 @@ protected void handleToNonVisibleButton(Event e) { return; } IStructuredSelection structuredSelection = visibleViewer.getStructuredSelection(); - @SuppressWarnings("unchecked") List selVCols = structuredSelection.toList(); getVisible().removeAll(selVCols); getNonVisible().addAll(selVCols); @@ -594,7 +589,6 @@ IColumnUpdater doGetColumnUpdater() { private void updateWidth() { try { int width = Integer.parseInt(widthText.getText()); - @SuppressWarnings("unchecked") T data = (T) visibleViewer.getStructuredSelection().getFirstElement(); if (data != null) { IColumnUpdater updater = getColumnUpdater(); diff --git a/bundles/org.eclipse.ui.views.log/src/org/eclipse/ui/internal/views/log/EventDetailsDialog.java b/bundles/org.eclipse.ui.views.log/src/org/eclipse/ui/internal/views/log/EventDetailsDialog.java index dfdd3e5f3d2..ee385283d5e 100644 --- a/bundles/org.eclipse.ui.views.log/src/org/eclipse/ui/internal/views/log/EventDetailsDialog.java +++ b/bundles/org.eclipse.ui.views.log/src/org/eclipse/ui/internal/views/log/EventDetailsDialog.java @@ -492,6 +492,7 @@ private boolean nextChildExists(AbstractEntry originalEntry, AbstractEntry origi /** * Sets entry children (Prev-Next navigable) to top-level elements */ + @SuppressWarnings("unchecked") private void setEntryChildren() { AbstractEntry[] children = getElements(); @@ -505,6 +506,7 @@ private void setEntryChildren() { /** * Sets entry children (Prev-Next navigable) to children of given entry */ + @SuppressWarnings("unchecked") private void setEntryChildren(AbstractEntry entry) { Object[] children = entry.getChildren(entry); diff --git a/bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/view/TabDescriptor.java b/bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/view/TabDescriptor.java index 264637cb417..f3a0b0dca1f 100755 --- a/bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/view/TabDescriptor.java +++ b/bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/view/TabDescriptor.java @@ -147,6 +147,7 @@ public String getCategory() { * @param target * the section descriptor to append. */ + @SuppressWarnings("unchecked") protected boolean append(ISectionDescriptor target) { if (!target.getTargetTab().equals(id)) { return false; @@ -168,6 +169,7 @@ protected boolean append(ISectionDescriptor target) { * @return true if the target descriptor was added to the * descriptors list. */ + @SuppressWarnings("unchecked") private boolean insertSectionDescriptor(ISectionDescriptor target) { if (target.getAfterSection().equals(TOP)) { getSectionDescriptors().add(0, target); diff --git a/bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/view/TabbedPropertyRegistry.java b/bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/view/TabbedPropertyRegistry.java index 4fe33d3c743..94782db3316 100755 --- a/bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/view/TabbedPropertyRegistry.java +++ b/bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/view/TabbedPropertyRegistry.java @@ -308,6 +308,7 @@ protected ITabDescriptor[] filterTabDescriptors( * Given a property tab descriptor remove all its section descriptors that * do not apply to the given input object. */ + @SuppressWarnings("unchecked") protected ITabDescriptor adaptDescriptorFor(ITabDescriptor target, IWorkbenchPart part, ISelection selection) { List filteredSectionDescriptors = new ArrayList<>(); diff --git a/bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/view/TabbedPropertyRegistryClassSectionFilter.java b/bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/view/TabbedPropertyRegistryClassSectionFilter.java index 12fbe21da10..8f29643a580 100755 --- a/bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/view/TabbedPropertyRegistryClassSectionFilter.java +++ b/bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/view/TabbedPropertyRegistryClassSectionFilter.java @@ -125,6 +125,7 @@ private boolean appliesToEffectiveType(ISectionDescriptor descriptor, ArrayList classTypes = getClassTypes(inputClass); + @SuppressWarnings("unchecked") List sectionInputTypes = descriptor.getInputTypes(); for (String type : sectionInputTypes) { if (classTypes.contains(type)) { diff --git a/bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/views/properties/tabbed/AbstractTabDescriptor.java b/bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/views/properties/tabbed/AbstractTabDescriptor.java index 5eba27f0840..27d5524e6c3 100644 --- a/bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/views/properties/tabbed/AbstractTabDescriptor.java +++ b/bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/views/properties/tabbed/AbstractTabDescriptor.java @@ -72,6 +72,7 @@ public TabContents createTab() { return tab; } + @SuppressWarnings("unchecked") @Override public boolean equals(Object object) { if (object == null) { diff --git a/bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/views/properties/tabbed/TabbedPropertySheetPage.java b/bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/views/properties/tabbed/TabbedPropertySheetPage.java index e8f0b197b71..5092dee24ee 100644 --- a/bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/views/properties/tabbed/TabbedPropertySheetPage.java +++ b/bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/views/properties/tabbed/TabbedPropertySheetPage.java @@ -616,6 +616,7 @@ public void resizeScrolledComposite() { * @param tabs tabs to dispose * @since 3.6 */ + @SuppressWarnings("unchecked") protected void disposeTabs(@SuppressWarnings("rawtypes") Collection tabs) { for (Iterator iter = tabs.iterator(); iter.hasNext();) { TabContents tab = iter.next(); diff --git a/bundles/org.eclipse.ui.workbench/.settings/org.eclipse.jdt.core.prefs b/bundles/org.eclipse.ui.workbench/.settings/org.eclipse.jdt.core.prefs index aa33bf2e930..cd7191299e1 100644 --- a/bundles/org.eclipse.ui.workbench/.settings/org.eclipse.jdt.core.prefs +++ b/bundles/org.eclipse.ui.workbench/.settings/org.eclipse.jdt.core.prefs @@ -116,7 +116,7 @@ org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore org.eclipse.jdt.core.compiler.problem.terminalDeprecation=warning org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning org.eclipse.jdt.core.compiler.problem.unavoidableGenericTypeProblems=disabled -org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning +org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=ignore org.eclipse.jdt.core.compiler.problem.unclosedCloseable=warning org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=ignore org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/activities/ActivityCategoryPreferencePage.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/activities/ActivityCategoryPreferencePage.java index f00157537d6..5ff032b9c1b 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/activities/ActivityCategoryPreferencePage.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/activities/ActivityCategoryPreferencePage.java @@ -187,7 +187,6 @@ public void activityManagerChanged(ActivityManagerEvent activityManagerEvent) { } private class CategoryContentProvider implements IStructuredContentProvider { - @SuppressWarnings("unchecked") @Override public Object[] getElements(Object inputElement) { // convert to category objects diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/commands/AbstractHandler.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/commands/AbstractHandler.java index b972997b74a..2a3c7da92c8 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/commands/AbstractHandler.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/commands/AbstractHandler.java @@ -41,7 +41,6 @@ * @noextend This class is not intended to be extended by clients. */ @Deprecated(forRemoval = true, since = "2024-03") -@SuppressWarnings({ "unchecked" }) public abstract class AbstractHandler extends org.eclipse.core.commands.AbstractHandler implements IHandler { /** diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/databinding/typed/WorkbenchProperties.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/databinding/typed/WorkbenchProperties.java index 332b2edbabf..daeb2fcd53c 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/databinding/typed/WorkbenchProperties.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/databinding/typed/WorkbenchProperties.java @@ -102,7 +102,6 @@ public static IValueProperty singleSelect * * @return an observable value */ - @SuppressWarnings("unchecked") public static IValueProperty singleSelection(String partId, boolean postSelection) { return (IValueProperty) singleSelection(partId, postSelection, Object.class); @@ -131,7 +130,6 @@ public static IValueProperty singleSelect * * @return an observable value */ - @SuppressWarnings("unchecked") public static IListProperty multipleSelection() { return (IListProperty) multipleSelection(Object.class); } @@ -160,7 +158,6 @@ public static IListProperty multipleSelec * * @return an observable value */ - @SuppressWarnings("unchecked") public static IListProperty multipleSelection(String partId, boolean postSelection) { return (IListProperty) multipleSelection(partId, postSelection, Object.class); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ShowViewMenu.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ShowViewMenu.java index 7fe4214550b..1c32242be9d 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ShowViewMenu.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ShowViewMenu.java @@ -234,7 +234,6 @@ public String getPluginId() { } - @SuppressWarnings("unchecked") private CommandContributionItemParameter getItem(String viewId) { MApplication application = window.getService(MApplication.class); List descriptors = application.getDescriptors(); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/databinding/AdaptedValueProperty.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/databinding/AdaptedValueProperty.java index fc74e304774..302c4bc80b8 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/databinding/AdaptedValueProperty.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/databinding/AdaptedValueProperty.java @@ -20,7 +20,6 @@ public Object getValueType() { return adapter; } - @SuppressWarnings("unchecked") @Override protected T doGetValue(S source) { if (adapter.isInstance(source)) diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/databinding/SelectionServiceListener.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/databinding/SelectionServiceListener.java index fc5660c6bb1..e79478f5949 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/databinding/SelectionServiceListener.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/databinding/SelectionServiceListener.java @@ -54,7 +54,6 @@ protected void doRemoveFrom(S source) { } } - @SuppressWarnings("unchecked") @Override public void selectionChanged(IWorkbenchPart part, ISelection selection) { // Note that the part is not the same object as the selection service, but it is diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/databinding/SingleSelectionProperty.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/databinding/SingleSelectionProperty.java index 329d8821fa5..0baa077703a 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/databinding/SingleSelectionProperty.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/databinding/SingleSelectionProperty.java @@ -33,7 +33,6 @@ protected T doGetValue(S source) { selection = ((ISelectionService) source).getSelection(); } if (selection instanceof IStructuredSelection) { - @SuppressWarnings("unchecked") T elem = (T) ((IStructuredSelection) selection).getFirstElement(); return elem; } diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ContentTypesPreferencePage.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ContentTypesPreferencePage.java index c6b1a2f01d6..497116e0e9f 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ContentTypesPreferencePage.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ContentTypesPreferencePage.java @@ -474,7 +474,6 @@ public void keyReleased(KeyEvent e) { } - @SuppressWarnings("unchecked") private void createFileAssociations(final Composite parent) { Composite composite = new Composite(parent, SWT.NONE); composite.setLayout(new GridLayout(2, false)); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java index 94c2e57eda6..e7779afae7f 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java @@ -392,7 +392,6 @@ public String getText(Object element) { }); } - @SuppressWarnings("unchecked") private void selectColorsAndFontsTheme(String colorAndFontThemeId) { if (colorAndFontThemeId == null) { colorAndFontThemeId = currentColorsAndFontsTheme.getId(); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/e4/migration/PerspectiveBuilder.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/e4/migration/PerspectiveBuilder.java index b6627f1af4f..c035d2e775c 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/e4/migration/PerspectiveBuilder.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/e4/migration/PerspectiveBuilder.java @@ -362,7 +362,6 @@ private void correctSelectedElements(MUIElement element) { if (!(element instanceof MPartSashContainer || element instanceof MPartStack)) { return; } - @SuppressWarnings("unchecked") MElementContainer container = (MElementContainer) element; List children = container.getChildren(); if (container.getSelectedElement() == null && !children.isEmpty()) { diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/LegacyHandlerService.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/LegacyHandlerService.java index 3d9d3b69fff..58609b925fb 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/LegacyHandlerService.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/LegacyHandlerService.java @@ -96,7 +96,6 @@ public Object compute(IEclipseContext context, String contextKey) { HashSet activationSet = new LinkedHashSet<>(); IEclipseContext current = context; while (current != null) { - @SuppressWarnings("unchecked") List handlerActivations = (List) current .getLocal(LEGACY_H_ID + commandId); if (handlerActivations != null) { @@ -177,7 +176,6 @@ private static IHandlerActivation registerLegacyHandler(final IEclipseContext co } static void addHandlerActivation(HandlerActivation eActivation) { - @SuppressWarnings("unchecked") List handlerActivations = (List) eActivation.context .getLocal(LEGACY_H_ID + eActivation.getCommandId()); if (handlerActivations == null) { @@ -194,7 +192,6 @@ static void addHandlerActivation(HandlerActivation eActivation) { } static void removeHandlerActivation(HandlerActivation eActivation) { - @SuppressWarnings("unchecked") List handlerActivations = (List) eActivation.context .getLocal(LEGACY_H_ID + eActivation.getCommandId()); if (handlerActivations == null) { diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/BindingService.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/BindingService.java index b0a36b67ffd..b014b6eb511 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/BindingService.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/BindingService.java @@ -604,7 +604,6 @@ static public MKeyBinding createOrUpdateMKeyBinding(MApplication application, MB keyBinding.setKeySequence(binding.getTriggerSequence().toString()); for (Object obj : parmCmd.getParameterMap().entrySet()) { - @SuppressWarnings({ "unchecked" }) Map.Entry entry = (Map.Entry) obj; String paramID = entry.getKey(); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/EditorRegistry.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/EditorRegistry.java index 667f53b8a2b..e1a80181a5c 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/EditorRegistry.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/EditorRegistry.java @@ -1163,7 +1163,6 @@ public FileEditorMapping get(String key) { * @return the mappings */ public FileEditorMapping[] allMappings() { - @SuppressWarnings("unchecked") HashMap merge = (HashMap) defaultMap.clone(); merge.putAll(map); Collection values = merge.values(); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/FileEditorMapping.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/FileEditorMapping.java index 29050a067a0..583e7ef8903 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/FileEditorMapping.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/FileEditorMapping.java @@ -91,7 +91,6 @@ public void addEditor(EditorDescriptor editor) { /** * Clone the receiver. */ - @SuppressWarnings("unchecked") @Override public Object clone() { try { diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/WorkbenchStatusDialogManagerImpl.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/WorkbenchStatusDialogManagerImpl.java index ea7ae5795b1..50d1d6b5b3f 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/WorkbenchStatusDialogManagerImpl.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/WorkbenchStatusDialogManagerImpl.java @@ -484,7 +484,6 @@ public Map getDialogState() { * * @return Collection of StatusAdapters */ - @SuppressWarnings("unchecked") private Collection getErrors() { return (Collection) dialogState.get(IStatusDialogConstants.STATUS_ADAPTERS); } diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/themes/RGBVisibleContrastColorFactory.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/themes/RGBVisibleContrastColorFactory.java index f8c08f220fe..6968f270c73 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/themes/RGBVisibleContrastColorFactory.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/themes/RGBVisibleContrastColorFactory.java @@ -99,7 +99,6 @@ public RGB createColor() { public void setInitializationData(IConfigurationElement config, String propertyName, Object data) throws CoreException { if (data instanceof Hashtable) { - @SuppressWarnings("unchecked") Hashtable table = (Hashtable) data; fg = table.get("foreground"); //$NON-NLS-1$ bg = table.get("background"); //$NON-NLS-1$ diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/part/PageBookView.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/part/PageBookView.java index a3d1cd56011..e06f6f5aef3 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/part/PageBookView.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/part/PageBookView.java @@ -468,7 +468,6 @@ public void dispose() { removePage(defaultPageRec, false); defaultPageRec = null; } - @SuppressWarnings("unchecked") Map clone = (Map) ((HashMap) mapPartToRec) .clone(); clone.values().forEach(rec -> removePage(rec, true)); diff --git a/tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/HeadlessApplicationTest.java b/tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/HeadlessApplicationTest.java index 498aea27fd1..b826bb37f9a 100644 --- a/tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/HeadlessApplicationTest.java +++ b/tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/HeadlessApplicationTest.java @@ -284,6 +284,7 @@ protected String getEngineURI() { return "bundleclass://org.eclipse.e4.ui.tests/org.eclipse.e4.ui.tests.application.HeadlessContextPresentationEngine"; //$NON-NLS-1$ } + @SuppressWarnings("unchecked") private void processPartContributions(IEclipseContext context, Resource resource) { IExtensionRegistry registry = context.get(IExtensionRegistry.class); diff --git a/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/leaks/LeakTests.java b/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/leaks/LeakTests.java index ef1f0eff5e1..ef20ebf186e 100644 --- a/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/leaks/LeakTests.java +++ b/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/leaks/LeakTests.java @@ -82,6 +82,7 @@ public static void checkRef(ReferenceQueue queue, Reference ref) assertTrue("Reference not enqueued", flag); } + @SuppressWarnings("unchecked") private Reference createReference(ReferenceQueue queue, Object object) { return new PhantomReference<>(object, queue); } diff --git a/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/manual/ViewWithSaveables.java b/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/manual/ViewWithSaveables.java index 622a9fbf01a..c6b5e4c6b64 100644 --- a/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/manual/ViewWithSaveables.java +++ b/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/manual/ViewWithSaveables.java @@ -279,6 +279,7 @@ class DirtyObservableMap extends ComputedObservableMap { Diffs.createMapDiffSingleChange( writableValueToElement.get(event.getSource()), event.diff.getOldValue(), event.diff.getNewValue())); + @SuppressWarnings("unchecked") public DirtyObservableMap(IObservableSet knownElements) { super(knownElements); init(); diff --git a/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/statushandlers/LabelProviderWrapperTest.java b/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/statushandlers/LabelProviderWrapperTest.java index 7c6fc74790f..9c8788f0f0d 100644 --- a/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/statushandlers/LabelProviderWrapperTest.java +++ b/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/statushandlers/LabelProviderWrapperTest.java @@ -46,6 +46,7 @@ public class LabelProviderWrapperTest { private LabelProviderWrapper wrapper; private Map dialogState = new HashMap<>(); + @SuppressWarnings("unchecked") @Before public void setUp() throws Exception { dialogState = new HashMap<>(); @@ -118,6 +119,7 @@ public void testImages(){ /* * StatusAdapter contains all information necessary to display the dialog. */ + @SuppressWarnings("unchecked") @Test public void testProvidedText_1(){ final String title = "title";