-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Home-Assistant autodiscovery MQTT #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your changes! After review issues are addressed I'll do a PR upstream.
Yes, I use HA myself -- currently, I'm doing some of this info in HA templates (like the charge state text), but I think it's a decent idea to move it into MQTT.
Sweet. Overall, it looks good enough at this point. But, I would like to lock these changes behind a CLI flag, like After that, I'm ok with it as-is. |
I can merge this now -- thanks for all of your work on it! I do still have some small areas of contention, but you might have your reasons for them -- For example, I think the SOC should perhaps be HA's Thanks for your contribution! |
I am glad i can contribute... Maybe one day we can reach the point that it is possible to write to the register to change the settings of the Classic. Thanks! |
Hello,
i added some code for HA autodiscovery so the Classic shows up as a MQTT device.
It also sends different icons for the chargestate and SOC.
Do you (eode) use HA?
Greetings!
(and thank you for fixing the python 3 stuff)