New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: clear favicon when the favicon is removed #252

Closed
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@EvanHahn
Contributor

EvanHahn commented Nov 15, 2017

Closes #247.

Before:

bad

After:

good

@eoger

Thanks a lot for investigating the problem and taking some time to make a PR!

Show outdated Hide outdated src/tab.js
Show outdated Hide outdated src/tab.js
@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Nov 17, 2017

Contributor

I believe I've addressed your comments. Lemme know if things look good!

Contributor

EvanHahn commented Nov 17, 2017

I believe I've addressed your comments. Lemme know if things look good!

@eoger

This comment has been minimized.

Show comment
Hide comment
@eoger

eoger Nov 18, 2017

Owner

Thank you, merged in ffa0ac4 (made a quick change)

Owner

eoger commented Nov 18, 2017

Thank you, merged in ffa0ac4 (made a quick change)

@eoger eoger closed this Nov 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment