Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: clear favicon when the favicon is removed #252

Closed
wants to merge 1 commit into from

Conversation

@EvanHahn
Copy link
Contributor

@EvanHahn EvanHahn commented Nov 15, 2017

Closes #247.

Before:

bad

After:

good

Copy link
Owner

@eoger eoger left a comment

Thanks a lot for investigating the problem and taking some time to make a PR!

src/tab.js Outdated
this._iconView.style.backgroundImage = "";
};
},
removeIcon() {

This comment has been minimized.

@eoger

eoger Nov 15, 2017
Owner

Can we call that resetIcon to be consistent with resetThumbnail?

src/tab.js Outdated
@@ -133,15 +133,19 @@ SideTab.prototype = {
toggleClass(this._iconOverlayView, "muted", muted);
},
updateIcon(favIconUrl) {

This comment has been minimized.

@eoger

eoger Nov 15, 2017
Owner

Instead of changing that method, how about we call resetIcon directly here:

setIcon(tab) {
let sidetab = this.getTab(tab);
if (sidetab) {
sidetab.updateIcon(tab.favIconUrl);
}
},

@EvanHahn EvanHahn force-pushed the EvanHahn:clear-favicon branch from 2024b3f to 40037eb Nov 17, 2017
@EvanHahn
Copy link
Contributor Author

@EvanHahn EvanHahn commented Nov 17, 2017

I believe I've addressed your comments. Lemme know if things look good!

@eoger
Copy link
Owner

@eoger eoger commented Nov 18, 2017

Thank you, merged in ffa0ac4 (made a quick change)

@eoger eoger closed this Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.