Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use === instead of == across the codebase #259

Closed
wants to merge 1 commit into from

Conversation

EvanHahn
Copy link
Contributor

@EvanHahn EvanHahn commented Nov 17, 2017

Various sources recommend using === instead of == to check equality in JavaScript. This PR enforces this with ESLint and then fixes all violations.

Curious to know what you think about this!

Various sources recommend using `===` instead of `==` to check equality
in JavaScript. This commit [enforces this with
ESLint](https://eslint.org/docs/rules/eqeqeq) and then fixes all
violations.
@eoger
Copy link
Owner

@eoger eoger commented Dec 16, 2017

Rebased and merged in 29f68bf, sorry it took so long, thanks!

@eoger eoger closed this Dec 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants