Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use secrets for env variables? #14

Open
muety opened this issue Sep 21, 2019 · 0 comments
Open

Use secrets for env variables? #14

muety opened this issue Sep 21, 2019 · 0 comments

Comments

@muety
Copy link

muety commented Sep 21, 2019

I'm still quite new to Kubernetes, but I've read that Kubernetes secrets provide a way to securely pass credentials etc. to containers.
In kubernetes/api-deployment.yaml, CLIENT_ID etc. are hard-coded, which is probably not a good practice, since those files are mentioned to be committed to VCS. I'd like to have the workshop being extended in a way that it should how to properly handle such confidential variables 🙂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant