Skip to content
This repository has been archived by the owner on Jun 7, 2019. It is now read-only.

Symbolic suffix was added twice for icons media-skip-backward, media-playback-start, media-playback-stop, and media-skip-forward #157

Closed
german-rios-gonzalez opened this issue Apr 3, 2014 · 0 comments

Comments

@german-rios-gonzalez
Copy link

The file "player.js" use the class PlayerButton from the file "widget.js" in this way (note the use of the suffix -symbolic):

    this._prevButton = new Widget.PlayerButton('media-skip-backward-symbolic',
        Lang.bind(this, function () { this._mediaServerPlayer.PreviousRemote(); }));
    this._playButton = new Widget.PlayerButton('media-playback-start-symbolic',
        Lang.bind(this, function () { this._mediaServerPlayer.PlayPauseRemote(); }));
    this._stopButton = new Widget.PlayerButton('media-playback-stop-symbolic',
        Lang.bind(this, function () { this._mediaServerPlayer.StopRemote(); }));
    this._stopButton.hide();
    this._nextButton = new Widget.PlayerButton('media-skip-forward-symbolic',
        Lang.bind(this, function () { this._mediaServerPlayer.NextRemote(); }));

And the class PlayerButton add again the -symbolic suffix here:

setIcon: function(icon) {
this.icon.icon_name = icon + '-symbolic';

The extension works because the especial GTK+ fallback use of symbolic icons, for example it looks for media-skip-backward-symbolic-symbolic, and not finding it, removes the -symbolic suffix, and because it can find the now media-skip-backward-symbolic you didn't notice this before.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant